Bug 195513

Summary: Actions after finishing download are smart but considered harmful
Product: [Applications] kget Reporter: squan
Component: generalAssignee: KGet authors <kget>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description squan 2009-06-07 00:25:19 UTC 
KGet allows to configure an action after downloads have finished.
That's nice.
But at 1st it has a bug:
Once configured you will have a hard time to use kget and to get rid of this option - because this action is always triggered a few seconds after starting kget again!
This means either kget gets unusable because it terminates itself after being started (because there are no active downloads) or - even worse - it shuts down the computer!

The 2nd point to be considered here is the shutdown option in conjunction with
kget being configured as download manager of konqueror: 
Even an experienced user may not think of the consequences and will experience shutdowns when doing the next download (may be days or weeks after activating the option), data loss is probable (the user may be have open documents).
Also users may be clueless about the reason of the shutdown or even interprete it as an X or KDE crash.

My proposal: If kget shuts down the system, there must be a notification with the possibility to cancel the shutdown.
Or alternatively the shutdown option should shutdown only once on each activation.
Comment 1 Lukas Appelhans 2009-06-07 00:38:07 UTC 
What version of KGet are u using?

Lukas
Comment 2 squan 2009-06-07 13:37:08 UTC 
I use KGet Version 2.2.88
Unter KDE 4.2.88 (KDE 4.2.88 (KDE 4.3 >= 20090527)) "release 3"
Comment 3 Matthias Fuchs 2010-02-08 22:53:03 UTC 
SVN commit 1087364 by mfuchs:

KGet also supports suspending and hibernating after all downloads are finished. Now then there is also a KNotification shown with a way to abort the action.
BUG: 224429
BUG: 195513
BUG: 194962

 M  +2 -0      conf/preferencesdialog.cpp  
 M  +87 -57    core/kget.cpp  
 M  +11 -25    core/kget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1087364