Bug 195494

Summary: Deleting and cancelling a picture with the keyboard still delete the picture
Product: [Applications] digikam Reporter: Alexandre Racine <alexandreracine>
Component: Albums-TrashAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: marcel.wiesweg
Priority: NOR    
Version: 0.10.0   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In: 7.5.0
Attachments: 1delete
2cancel
3picISgone

Description Alexandre Racine 2009-06-06 20:15:33 UTC 
Version:           0.10.0 (using 4.2.2 (KDE 4.2.2), Kubuntu packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.28-12-generic

That's a weird one.

See screenshots for the visual result.

1-Go in an album with multiples pictures.
2-Delete a picture
3-With the keyboard, hit the right arrow to move the selection to "cancel"
4-Hit enter and your picture will still be deleted!
Comment 1 Alexandre Racine 2009-06-06 20:16:07 UTC 
Created attachment 34330 [details]
1delete
Comment 2 Alexandre Racine 2009-06-06 20:16:22 UTC 
Created attachment 34331 [details]
2cancel
Comment 3 Alexandre Racine 2009-06-06 20:16:38 UTC 
Created attachment 34332 [details]
3picISgone
Comment 4 caulier.gilles 2009-06-06 22:32:22 UTC 
SVN commit 978353 by cgilles:

Set Cancel button from delete dialog as default button with keyboard layout.
BUGS: 195494

 M  +1 -1      deletedialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=978353
Comment 5 Andi Clemens 2009-06-06 22:43:47 UTC 
Alexandre,

I guess you should have pressed SPACE instead of Enter. I guess Enter will use the default action.

Anyway the above commit should have fixed it now.

Andi
Comment 6 Alexandre Racine 2009-06-07 03:10:58 UTC 
Andi : Since we can move the selection, the blue contour, I don't think that having one key equalling a default, without indication, should be there. Especially not ENTER or SPACE.

Gilles : The problem if you put ENTER = an action, instead of ENTER = current highlighted option, is that I do actually use ENTER to delete too. So the correct way should be ENTER = current highlighted option. Does that sound more logic?  And if the first highlighted option is "delete" just like it is currently for me, this is good.
Comment 7 caulier.gilles 2009-06-19 12:20:13 UTC 
SVN commit 983830 by cgilles:

set focus to Cancel button
BUGS: 195494


 M  +1 -0      deletedialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=983830
Comment 8 Marcel Wiesweg 2009-06-20 12:44:29 UTC 
Gilles, this makes the normal workflow impossible: Press Del, press Enter to confirm. That's how it's done everywhere. No the result is: Press Del, press (blindly) Enter to confirm, nothing happens -> user is confused and files a bug that deleting does not work.
Comment 9 caulier.gilles 2009-06-20 14:26:19 UTC 
Right Marcel,
I Will fix it.

Gilles
Comment 10 caulier.gilles 2009-06-20 15:34:34 UTC 
SVN commit 984215 by cgilles:

wrap around focused button from Delete dialog. Sound like Qt and KDE api do not follow focus button set by keyboard.
CCBUGS: 195494


 M  +32 -5     deletedialog.cpp  
 M  +5 -1      deletedialog.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=984215