Bug 195323

Summary:	Add printer color space support in Print Assistant
Product:	[Applications] digikam	Reporter:	Michal Thoma <michal>
Component:	Plugin-Generic-PrintCreator	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	REPORTED ---
Severity:	wishlist	CC:	anaselli, caulier.gilles
Priority:	NOR
Version:	5.0.0
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Michal Thoma 2009-06-05 13:26:20 UTC

Version:            (using KDE 4.2.2)
OS:                Linux
Installed from:    Ubuntu Packages

I just tried Print Assistant and it's just awesome and helpful feature, much more useful then similar wizards in other DAM software I tried.

I miss only one thing - possibilty convert print batch to destination (printer) color space.

Some CM is commonly present in the printer driver though this could be turned off and so we can use our own printer profile (produced using Argyll or provided by the paper/ink manufactrer). It's essential especially in case of use of third party inks or papers in order to maximize output quality.

Comment 1 Angelo Naselli 2009-06-17 22:44:26 UTC

Gilles do you think it's hard to port digikam cms into printimages?

Comment 2 caulier.gilles 2009-06-18 09:07:57 UTC

Angelo,

It's not a trivial task. Color Management is a complex stuff.

1/ you need to be relied with littlecms library
2/ you need a codec to convert QImage image data from source color space to a target color space
3/ In digiKAm, we don't use QImage, but a dedicated container which support 16 bits color depth : DImg
4/ DImg CM codec is here : http://websvn.kde.org/trunk/extragear/graphics/digikam/libs/dimg/filters/icctransform.h?revision=949654&view=markup
5/ I recommend to checkout is a QImage CM codec already exist somewhere.
6/ You need a settings panel. digiKam code is there : http://websvn.kde.org/trunk/extragear/graphics/digikam/utilities/setup/setupicc.h?revision=949654&view=markup
7/ And finaly, to understand how CM work exactly (:=)))

Good luck

Gilles Caulier

Comment 3 Angelo Naselli 2009-06-18 11:05:06 UTC

argh, i believe it's too hard by now... can we add it as a summer of code task?

Comment 4 caulier.gilles 2017-07-16 14:59:48 UTC

Git commit c88e51cbe7b5569d6c7b8f75a0602fd47b19788e by Gilles Caulier.
Committed on 16/07/2017 at 14:34.
Pushed by cgilles into branch 'master'.

Print Creator: Use DImg instead QImage, this will permit to use color management later.
Move DImg to QImage conversion in separated thread to speed-up processing.
Related: bug 373024

M  +2    -2    utilities/assistants/printcreator/manager/advprinttask.cpp
M  +11   -17   utilities/assistants/printcreator/tools/advprintphoto.cpp
M  +15   -9    utilities/assistants/printcreator/tools/advprintphoto.h
M  +30   -15   utilities/assistants/printcreator/wizard/advprintcropframe.cpp

https://commits.kde.org/digikam/c88e51cbe7b5569d6c7b8f75a0602fd47b19788e