Bug 194997

Summary:	Python syntax highlighting missing TODO, FIXME, and NOTE keywords (Alerts)
Product:	[Applications] kate	Reporter:	Riskable <riskable>
Component:	syntax	Assignee:	KWrite Developers <kwrite-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jowenn
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Riskable 2009-06-02 16:42:57 UTC

Version:            (using KDE 4.2.2)
OS:                Linux
Installed from:    Ubuntu Packages

For some reason the Python syntax highlighting XML file is missing rules for Alerts like TODO, FIXME, and NOTE.  Not a big deal but every other language has these keywords highlighted so it seems like an accidental omission.

I'm sure that someone who's more familiar with the Kate highlighting XML files will be able to add these missing keywords with a simple copy & paste operation.  Probably just by including an "##Alerts" include line in the proper place (like it is in bash.xml).  I tried that myself but after a few permutations (using different locations and methods) I still wasn't getting these keywords highlighted.  Comments with "TODO" still show up entirely in grey.

Note:  After adding what I thought were the proper lines to python.xml I noticed that "Normal text" and "Alerts" showed up in Kate Settings->Fonts and Colors->Highlighting Text Styles (they didn't before).  Despite being present in the settings there was no change in the appearance of files in the editor.

Comment 1 Matthew Woehlke 2009-06-27 01:33:26 UTC

Patch pending review: http://reviewboard.kde.org/r/896/

Comment 2 Joseph Wenninger 2009-09-11 23:52:08 UTC

SVN commit 1022507 by jowenn:

Small addition: I've added # and ' as additional delimiters so 
'''ALERT
and
#ALERT 
are also highlighted, not only
''' ALERT
and
# ALERT

Adding those two characters as delimiters is not completely correct, but I don't see a real harm in it.

CCBUG:194997


 M  +3 -2      python.xml  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1022507