Bug 194695

Summary:	Site-specific JavaScript policy does not work
Product:	[Frameworks and Libraries] kwebkitpart	Reporter:	Michael <michael>
Component:	general	Assignee:	webkit-devel
Status:	RESOLVED FIXED
Severity:	normal	CC:	adawit
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Michael 2009-05-30 22:35:10 UTC

Version:            (using KDE 4.2.2)
Compiler:          GCC 4.3.3 Debian 4.3.3-10
OS:                Linux
Installed from:    Debian testing/unstable Packages

I've recently changed my Konqueror configuration to disable JavaScript on all web sites except for a few that need or want it (GMail, for instance). It works using KHTML, but WebKit doesn't enable JS on any web sites.

Comment 1 Urs Wolfer 2009-06-23 22:01:17 UTC

I have just noticed the same issue. It's valid for all options. I'm quite sure that I have had implemented that feature. After looking into the code, it looks like it got refactored... Now only global settings are set. Or do I miss something? Michael?

Comment 2 Michael 2009-06-24 03:39:09 UTC

I don't see any code in there that would allow for non-global settings. Looking for it in the commit log.

Comment 3 Michael 2009-06-24 03:48:12 UTC

(In reply to comment #2)
> I don't see any code in there that would allow for non-global settings. Looking
> for it in the commit log.

Ick. It's in WebKitSettings, but nothing in KWebPage. Trying to figure out how it works now.

Comment 4 Dawit Alemayehu 2009-10-19 18:05:00 UTC

SVN commit 1037620 by adawit:

- Added support for per site javascript policy.
- Do not set the new window meta data when createNewWindow is called so that 
  the user's preference is honored by Konqueror.
- Restore the scroll position when navigating back to a page.
- Added function to return the SSL information of the current site.

CCBUG:211065
CCBUG:209229
CCBUG:194695


 M  +29 -19    webkitpart.cpp  
 M  +193 -210  webpage.cpp  
 M  +11 -18    webpage.h  
 M  +0 -3      websslinfo.cpp  
 M  +1 -3      websslinfo.h  
 M  +2 -1      webview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1037620

Comment 5 Dawit Alemayehu 2009-10-23 01:07:41 UTC

See comment #4