| Summary: | KDEµBlog is wrong about when a micropost was published | ||
|---|---|---|---|
| Product: | [Plasma] plasma4 | Reporter: | Js Lebacq <js.lebacq> |
| Component: | widget-microblogging | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andresbajotierra, annma, aseigo, dan, jbrouault, karl, michael |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: |
Patch to set TimeSpec to UTC
Consider timestamps as UTC when displaying |
||
|
Description
Js Lebacq
2009-05-27 13:58:19 UTC
Is it with Twitter? Identi.ca? both? Does it happen only with new posts? Did you just open your account? Please add as much information as possible, thanks in advance. > "Is it with Twitter? Identi.ca? both?" I only use identi.ca > "Does it happen only with new posts?" The problem begin at the start of the app and for all the status displayed in the plasmoid. > "Did you just open your account?" No, I'm an older user of identi.ca than KDEµBlog. Also, for the moment it is always 1 or 2 hour more than the reality, like in my first example. Is there a pattern for the +1 or +2 hours? Is it correct on Identi.ca website? Did you only start using the applet now? Or did it work correctly some time back? > "Is there a pattern for the +1 or +2 hours?" Sorry, it seems I'm unable to find it. > "Is it correct on Identi.ca website?" Well, yes, as far as I can see. > "Did you only start using the applet now? Or did it work correctly some time back?" I began to use it one day ago. let me guess, your timezone is UTC+1 or UTC+2? :) SVN commit 973716 by aseigo: created_at (aka "Date" from the engine) is always in UTC, so don't use the current system time but the current UTC time to establish how long ago the tweet was made BUG:194302 M +21 -21 microblog.cpp M +4 -0 microblog.h WebSVN link: http://websvn.kde.org/?view=rev&revision=973716 Created attachment 36115 [details]
Patch to set TimeSpec to UTC
My timezone is UTC+2 and the microblogging widget always has a 2 hours shift.
Seems to be because the TimeSpec of the QDateTime created by toDateTime() is local instead of being UTC.
The attached patch set the TimeSpec to UTC.
This is still present on KDE4.3: bug 203949; so I guess it was not fixed properly or reappeared on 4.3.0 SVN commit 1013632 by jbrouault: Force the tweet date to UTC time spec to establish how long ago the tweet was posted. BUG:194302 BUG:203949 M +3 -1 microblog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1013632 SVN commit 1022729 by jbrouault: backport of r1013632 BUG:194302 BUG:203949 M +3 -1 microblog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1022729 *** Bug 203949 has been marked as a duplicate of this bug. *** Created attachment 40635 [details]
Consider timestamps as UTC when displaying
This is against the 4.4.0 tarball of KDE-Plasma-Addons, and based on the change in the patch applied to the 4.3 series.
The issue has reappeared in 4.4.0 and the previous patch no longer applies as the display has been split out to another file. The attached patch makes the same basic change as Jean-Baptiste's, but now in postwidget.cpp for the widget. It has solved the problem locally. I confirm that the issue is back on KDE 4.4, I just posted a new bug report, but will remove it if I see action. It's been a long time since I have applied a patch, can you point me to a "how-to" so I can fix and affirm? Thanks! Dan *** Bug 228676 has been marked as a duplicate of this bug. *** SVN commit 1096698 by annma: Thanks Michael for the patch, too bad I did not see this before 4.4.1 tagging, will only be in 4.4.2. Will fixe also in trunk BUG=194302 M +1 -0 postwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1096698 SVN commit 1096721 by annma: port 1096698 to trunk (fixe timeline) CCBUG=194302 M +1 -0 postwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1096721 |