| Summary: | Tabs in Koqueror are displayed improperly (regression) | ||
|---|---|---|---|
| Product: | [Plasma] Oxygen | Reporter: | Paweł Prażak <kojot350> |
| Component: | style | Assignee: | Camilla Boemann <cbo> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andresbajotierra, bugzilla.kde, hugo.pereira.da.costa, long, pano_90 |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Tabs bug screenshot
Fixed corner widgets location in konqueror and close tab button vertical alignment |
||
|
Description
Paweł Prażak
2009-05-24 15:19:36 UTC
Created attachment 33972 [details]
Tabs bug screenshot
Have you tested with another widget styles ? (just to see if it is a Konqueror or an Oxygen issue) Thanks I'd surely do it, but unfortunately it's not working for me :| See bug #193913 Any thoughts? I've just remembered good old 'konqueror --style motif' :D And yes, it looks like oxygen bug, because with motif it looks fine. That would explain a lot, since I've checked the konquerors source code and haven't found any obvious tab related bugs. I've should tried in other apps earlier, before assumption that it's konq's bug. It affects dolphin and kdevelop as well, but not the kmail(it has no close button on tabs). Have you tested with --style plastique or --style cleanlooks ? Yes, it works fine as well with plastique and cleanlooks. Reassigning to oxygen Thanks Dario :) > Open new tab and close tab tool buttons are displayed improperly, about 3px lower (see screen shot). We use PM_TabBarBaseOverlap, which doen't work well with Qt. > There is some kind of border between tab and tab content (about 3px) - see screen shot. That's already fixed in trunk. > Open new tab and close tab tool buttons are displayed improperly, about 3px lower (see screen shot). I don't know where this comes from, we don't do anything suspicious here, but I'll try to figure out... *** Bug 194377 has been marked as a duplicate of this bug. *** *** Bug 201903 has been marked as a duplicate of this bug. *** "The close button is displayed lower then it should be and it uses Qt's icon (rectangle one) instead of KDE's (round red one)." On the icon shape: this is a konqueror choice (as well as dophin) On the icon position (with respect to the tab text). As far as I can tell, the issue comes from the fact that the contents margin of the tab are well accounted for to place the tab *text* but are ignored to place the tab button (it is always centered vertically). Since the oxygen top and bottom margins are different (2 vs 4 pixmaps), this creates the observed misalignment. sorry. Typo: read (2 vs 4 pixels) sorry. Typo: read (2 vs 4 pixels) Created attachment 37677 [details]
Fixed corner widgets location in konqueror and close tab button vertical alignment
Fixed in trunk (see previous attachment) r1037814 r1037806 SVN commit 1038638 by hpereiradacosta: More fixing on tabwidget contents and tabbar layout. Fixes conflict between r1038325 and r1037814 (and layout for konqueror, konversation, etc.) CCBUG: 205094 CCBUG: 193893 M +12 -2 oxygen.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1038638 |