Bug 193734

Summary: Closing geolocation correlator without saving shows two warning dialogs
Product: [Applications] digikam Reporter: Rick Wagner <rjwgnr27>
Component: Geolocation-CorrelatorAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed In: 0.7.0
Attachments: Fix double confirmation, patch against r1021240

Description Rick Wagner 2009-05-23 09:20:53 UTC
Version:           digikam 0.10.0 / kipi-plugins 0.2.0 (using KDE 4.2.3)
OS:                Linux
Installed from:    Fedora RPMs

When closing the geolocation correlator without saving, two duplicate warning dialogs are shown.  The warning dialog has the title "Warning - digiKam", with the text: "1 image from the list is not updated. Do you really want to close this window without applying changes?"

Clicking "Yes" displays the same warning a second time.  Clicking "Yes" then returns to the album view.
Comment 1 Michael G. Hansen 2009-09-08 18:10:35 UTC
Created attachment 36796 [details]
Fix double confirmation, patch against r1021240

Issue was still present in 0.6+svn, fixed by attached patch. Basically "close" needs to be only confirmed in the closeEvent-handler, where it can be rejected or accepted. The "slotClose" only called close manually, thus the double warning.
Comment 2 caulier.gilles 2009-09-09 16:28:10 UTC
SVN commit 1021568 by cgilles:

fix double confirmation at close dialog
BUGS: 193734


 M  +0 -10     gpssyncdialog.cpp  
 M  +0 -1      gpssyncdialog.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1021568