Summary: | no previews in filemanagers and folderview widget for icons below 64x64 | ||
---|---|---|---|
Product: | [Frameworks and Libraries] kdelibs | Reporter: | Janet <bugzilla> |
Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andresbajotierra, finex, peter.penz19 |
Priority: | NOR | ||
Version: | 4.2 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Janet
2009-05-22 00:24:36 UTC
confirmed in trunk too. Here using: Qt: 4.5.1 (qt-copy 971295) KDE: 4.2.91 (KDE 4.2.91 (KDE 4.3 >= 20090609)) kdelibs svn rev. 982117 / kdebase svn rev. 982118 on ArchLinux i686 - Kernel 2.6.29.4 I can't reproduce this. Can anyone else confirm this? Thanks I can reproduce with: kde svn r982192 qt 4.5.1-3 Just create a 5x5 pixels image and enable preview in dolphin. Oops.. I misunderstood something.. Indeed, this is still valid: From "KFilePreviewGenerator" code: Function "void KFilePreviewGenerator::Private::addToPreviewQueue(const KFileItem& item, const QPixmap& pixmap)" called when the preview was already generated for that item: " const QSize size = m_viewAdapter->iconSize(); if ((pixmap.width() < size.width()) && (pixmap.height() < size.height())) { // If the width and the height are smaller than the available size, an old // preview has been received, where the available size was smaller. Note that // no check for a larger icon size is done, as a downscaling will be done // anyhow. return; } " I checked and this cases are hitting this. --- Weird enough: I had a 45x2 jpg image in a folder. With a >32 preview size, (at first), no preview was shown Then, changing to 32px will show the preview. From now on, increasing the preview size will still show the preview But values <32 won't show it. Pretty weird -- I wonder if this could be cause by some code change on KIO::PreviewJob or in the thumbnail:/ preview creators -- @Peter: your name is on the KFilePreviewGenerator code :) BTW: that code was introduced at: http://websvn.kde.org/?view=rev&revision=947588 Solved I guess? At least I cannot reproduce the problem anymore. Thanks Janet - yes, this bug has been fixed in the meantime :-) |