Bug 193046

Summary:	performance issue with new search function
Product:	[Applications] kate	Reporter:	Rico Zienke <zonken>
Component:	search	Assignee:	KWrite Developers <kwrite-bugs-null>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	christoph, eibl, kde-2011.08, kwrite-bugs-null, shentey
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Rico Zienke 2009-05-17 21:18:23 UTC

Version:            (using KDE 4.2.2)
OS:                Linux
Installed from:    Ubuntu Packages

Hi,
the search function changed in kate with KDE 4. In general it is very good but there are two things, which makes not easier (compared with the old search dialog in kate):

1)
When I edit a long file (more then 150000 lines) and press Crtl+F and enter quickly a pattern eg. "exa" following happens:
- the first 10 seconds nothing happen,
- now all hits with "e" will be highlighted of course there are a lot of "E" (I guess that causes the poor performance)
- now the input field reacts on my input "exa", it will be displayed in the input field,
- now again all patterns with "exa" will be highlighted. What I was looking for directly. This is now fast.

--> So the question is here, whether it makes sence to react on the first letter, I enter. Maybe it is better to wait until the first 3 letters are entered or the user press explicit search. 


2) I really miss the history of search pattern. Is there a way to add there again a drop down list box?

Best Regards Rico

Comment 1 Christian Eibl 2009-11-11 17:59:09 UTC

I second this. It is very annoying to wait for search hits after only having entered a few letters. In my opinion, an option to switch back to the KDE3 style dialog with all its options would be much better for power users editing large files -- although the new form is more stylish and fancy, of course ;-)

However, Rico, I just saw that the find/replace functionality provides searching the file only after explicitly pressing enter. Naturally, it wouldn't make sense to search during typing for replacing found strings...

Comment 2 Dominik Haumann 2010-05-08 03:28:37 UTC

In KDE 4.5, there is no find-as-you-type (correct Bernhard?).

So this is not an issue. But if introduced again, we should indeed consider doing it delayed depending on the size of the document...

If you want, you can try the current behavior already now by compiling it yourself (very easy!!): http://gitorious.org/kate/pages/Building%20Kate

If this is still or again an issue, please reopen.

Comment 3 Rico Zienke 2010-05-08 11:42:20 UTC

Hi,
@Christian E.: sorry I did not get/see a notification of your comment but thanks for the info.

In kate 3.4.2 there is an option in the search area where I can uncheck this function. With an update that setting was default and also solved my issues. (I just forgot to update this bug...)

I also build a new version from git to see the difference. This option is now away. For me it is okay too.
(by the way: I like the small pop up which shows the number of replacements after a replace all :-) In my opinion it should not cover any button or should vanish directly again after clicking into any UI element (search input field, etc.. )

I was also able to reproduce another issue in the git version that I realized these days. I will open another bug report for that.

Thanks for the update and good work!
Rico

Comment 4 Dominik Haumann 2010-05-08 11:51:33 UTC

Ok, given the initial issue of this report is then solved (no find-as-you-type anymore), I'll close this as fixed. If there are new issues, please open new reports, this way we keep them small such that we don't have to read tons of comments in order to get what needs to be done.

Thanks for your quick answer, Rico!

Comment 5 Dotan Cohen 2010-05-10 10:00:17 UTC

Find-as-you-type still exists in VI mode, just press "/".

Comment 6 Dominik Haumann 2010-05-10 12:27:02 UTC

@Dotan: ok, but if there are issues, please open a new report for that.

Comment 7 Bernhard Beschow 2010-05-11 15:17:48 UTC

@Dominik: There is a difference in behavior for the incremental vs. the power search bar. The incremental search bar always finds-as-you-type, whereas the finding in the power search/replace bar has to be triggered manually.

Comment 8 Dominik Haumann 2010-05-11 23:59:51 UTC

@Bernhard: Does that mean to reopen this because of 1)?

(btw. 2) history of search pattern is implemented)

Comment 9 Bernhard Beschow 2010-05-12 00:17:08 UTC

@Dominik: No, I think there is no reason to reopen the bug because of comment #3 and the fact that the performance issue was caused by finding all occurrences, which got removed from the search bar for KDE 4.5 anyway.