Bug 192851

Summary: Cannot Transfer m4a to iPod
Product: [Applications] amarok Reporter: Rashad Tatum <tatum.rashad>
Component: Collections/iPod iPhoneAssignee: Amarok Bugs <amarok-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: aikawarazuni, ashl1future, matej, netz, zjons
Priority: NOR    
Version First Reported In: 2.2-SVN   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: 2.1.1 Patch - Add mp4 to ipod accepted formats

Description Rashad Tatum 2009-05-16 10:24:01 UTC
Version:            (using KDE 4.2.3)
OS:                Linux
Installed from:    Ubuntu Packages

The title explains the bug.  Attempting to copy m4a files to iPod does not work.
Comment 1 Rashad Tatum 2009-05-16 10:32:31 UTC
And I will work on this bug.
Comment 2 Zee Jones 2009-05-30 20:51:42 UTC
I see the same in the Amarok 2.1-SVN built from the Gentoo kde-testing overlay

Using:
taglb-1.5
taglib-extras-9999 (kde-testing)
OS:    Linux (i686) release 2.6.27-gentoo-r10,  KDE: 4.2.3,  Qt: 4.5.1
iPod: Model A1236

m4a files encoded with either iTunes or NeroAacEnc play fine and are handled correctly by Amarok whether they are in the local collection or on the iPod.  mp3 files are transferred without problems to the iPod, including cover art (Nice!).
m4a files simply do not transfer (no crash, no complaint, just silently ignored).
Comment 3 Myriam Schweingruber 2009-07-16 09:56:50 UTC
Changing to confirmed then.
Comment 4 Alejandro Wainzinger 2009-07-17 07:44:35 UTC
SVN commit 998172 by awainzinger:

Add m4a to supported formats list for ipod.  Really should be testing this depending on iPod model, but can't find way to do that in libgpod atm, maybe later.
BUG:192851

 M  +1 -1      IpodHandler.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=998172
Comment 5 Rashad Tatum 2009-07-17 08:28:47 UTC
I think their will still be problems transferring files of other types if
only the files listed in the QStringList formats are allowed.

The iPod allows for several other formats see the following site:
http://www.apple.com/ipodclassic/specs.html

Also please take a look at the gtkpod source at:
http://gtkpod.svn.sourceforge.net/viewvc/gtkpod/gtkpod/trunk/src/file.c?view=markup

On Fri, Jul 17, 2009 at 1:44 AM, Alejandro Wainzinger <
aikawarazuni@gmail.com> wrote:

> https://bugs.kde.org/show_bug.cgi?id=192851
>
>
> Alejandro Wainzinger <aikawarazuni@gmail.com> changed:
>
>           What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>             Status|NEW                         |RESOLVED
>         Resolution|                            |FIXED
>
>
>
>
> --- Comment #4 from Alejandro Wainzinger <aikawarazuni gmail com>
>  2009-07-17 07:44:35 ---
> SVN commit 998172 by awainzinger:
>
> Add m4a to supported formats list for ipod.  Really should be testing this
> depending on iPod model, but can't find way to do that in libgpod atm,
> maybe
> later.
> BUG:192851
>
>  M  +1 -1      IpodHandler.cpp
>
>
> WebSVN link: http://websvn.kde.org/?view=rev&revision=998172
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are a voter for the bug.
> You reported the bug.
>
Comment 6 Alejandro Wainzinger 2009-07-17 09:18:59 UTC
When you say "the iPod" you speak as if there's one model, and that
it's the iPod classic.  There are several models, some of which share
filetype support, others seem not to.  It makes little sense to copy
an AIFF to the iPod Shuffle, for instance.  So, what I seek is a way
for libgpod to tell me directly: given this model, what formats does
this model support.

On Fri, Jul 17, 2009 at 8:28 AM, Rashad Tatum<tatum.rashad@gmail.com> wrote:
> https://bugs.kde.org/show_bug.cgi?id=192851
>
>
>
>
>
> --- Comment #5 from Rashad Tatum <tatum rashad gmail com>  2009-07-17 08:28:47 ---
> I think their will still be problems transferring files of other types if
> only the files listed in the QStringList formats are allowed.
>
> The iPod allows for several other formats see the following site:
> http://www.apple.com/ipodclassic/specs.html
>
> Also please take a look at the gtkpod source at:
> http://gtkpod.svn.sourceforge.net/viewvc/gtkpod/gtkpod/trunk/src/file.c?view=markup
>
> On Fri, Jul 17, 2009 at 1:44 AM, Alejandro Wainzinger <
> aikawarazuni@gmail.com> wrote:
>
>> https://bugs.kde.org/show_bug.cgi?id=192851
>>
>>
>> Alejandro Wainzinger <aikawarazuni@gmail.com> changed:
>>
>>           What    |Removed                     |Added
>>
>> ----------------------------------------------------------------------------
>>             Status|NEW                         |RESOLVED
>>         Resolution|                            |FIXED
>>
>>
>>
>>
>> --- Comment #4 from Alejandro Wainzinger <aikawarazuni gmail com>
>>  2009-07-17 07:44:35 ---
>> SVN commit 998172 by awainzinger:
>>
>> Add m4a to supported formats list for ipod.  Really should be testing this
>> depending on iPod model, but can't find way to do that in libgpod atm,
>> maybe
>> later.
>> BUG:192851
>>
>>  M  +1 -1      IpodHandler.cpp
>>
>>
>> WebSVN link: http://websvn.kde.org/?view=rev&revision=998172
>>
>> --
>> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
>> ------- You are receiving this mail because: -------
>> You are a voter for the bug.
>> You reported the bug.
>>
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.
>
Comment 7 Rashad Tatum 2009-07-17 14:09:53 UTC
Had you visited the link you would have noticed something called a
comparison chart that lists the formats supported for other models!

Between, AIFF is supported by Apple on the iPod shuffle, genius.  Especially
considering that it's an audio format that developed by Apple!

On Fri, Jul 17, 2009 at 3:19 AM, Alejandro Wainzinger <
aikawarazuni@gmail.com> wrote:

> https://bugs.kde.org/show_bug.cgi?id=192851
>
>
>
>
>
> --- Comment #6 from Alejandro Wainzinger <aikawarazuni gmail com>
>  2009-07-17 09:18:59 ---
> When you say "the iPod" you speak as if there's one model, and that
> it's the iPod classic.  There are several models, some of which share
> filetype support, others seem not to.  It makes little sense to copy
> an AIFF to the iPod Shuffle, for instance.  So, what I seek is a way
> for libgpod to tell me directly: given this model, what formats does
> this model support.
>
> On Fri, Jul 17, 2009 at 8:28 AM, Rashad Tatum<tatum.rashad@gmail.com>
> wrote:
> > https://bugs.kde.org/show_bug.cgi?id=192851
> >
> >
> >
> >
> >
> > --- Comment #5 from Rashad Tatum <tatum rashad gmail com>  2009-07-17
> 08:28:47 ---
> > I think their will still be problems transferring files of other types if
> > only the files listed in the QStringList formats are allowed.
> >
> > The iPod allows for several other formats see the following site:
> > http://www.apple.com/ipodclassic/specs.html
> >
> > Also please take a look at the gtkpod source at:
> >
> http://gtkpod.svn.sourceforge.net/viewvc/gtkpod/gtkpod/trunk/src/file.c?view=markup
> >
> > On Fri, Jul 17, 2009 at 1:44 AM, Alejandro Wainzinger <
> > aikawarazuni@gmail.com> wrote:
> >
> >> https://bugs.kde.org/show_bug.cgi?id=192851
> >>
> >>
> >> Alejandro Wainzinger <aikawarazuni@gmail.com> changed:
> >>
> >>           What    |Removed                     |Added
> >>
> >>
> ----------------------------------------------------------------------------
> >>             Status|NEW                         |RESOLVED
> >>         Resolution|                            |FIXED
> >>
> >>
> >>
> >>
> >> --- Comment #4 from Alejandro Wainzinger <aikawarazuni gmail com>
> >>  2009-07-17 07:44:35 ---
> >> SVN commit 998172 by awainzinger:
> >>
> >> Add m4a to supported formats list for ipod.  Really should be testing
> this
> >> depending on iPod model, but can't find way to do that in libgpod atm,
> >> maybe
> >> later.
> >> BUG:192851
> >>
> >>  M  +1 -1      IpodHandler.cpp
> >>
> >>
> >> WebSVN link: http://websvn.kde.org/?view=rev&revision=998172
> >>
> >> --
> >> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> >> ------- You are receiving this mail because: -------
> >> You are a voter for the bug.
> >> You reported the bug.
> >>
> >
> > --
> > Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> > ------- You are receiving this mail because: -------
> > You are on the CC list for the bug.
> >
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are a voter for the bug.
> You reported the bug.
>
Comment 8 Alejandro Wainzinger 2009-07-18 13:16:00 UTC
Well I did visit the link, during work, but I admit I just skimmed it quickly.  Since you seem passionate about the topic, why not write up a patch and send it in?
Comment 9 Rashad Tatum 2009-07-18 17:04:39 UTC
Okay.  I will probably write one up sometime this weekend.

On Sat, Jul 18, 2009 at 7:16 AM, Alejandro Wainzinger <
aikawarazuni@gmail.com> wrote:

> https://bugs.kde.org/show_bug.cgi?id=192851
>
>
> Alejandro Wainzinger <aikawarazuni@gmail.com> changed:
>
>           What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>              Status|RESOLVED                    |REOPENED
>         Resolution|FIXED                       |
>
>
>
>
> --- Comment #8 from Alejandro Wainzinger <aikawarazuni gmail com>
>  2009-07-18 13:16:00 ---
> Well I did visit the link, during work, but I admit I just skimmed it
> quickly.
> Since you seem passionate about the topic, why not write up a patch and
> send it
> in?
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are a voter for the bug.
> You reported the bug.
>
Comment 10 Rashad Tatum 2009-07-18 17:06:47 UTC
As a side note, I could not find a function in libgpod that determines the
supported file types.  I found that to be strange since there is a function
that gives the supported photo formats.

On Sat, Jul 18, 2009 at 11:04 AM, Rashad Tatum <tatum.rashad@gmail.com>wrote:

> Okay.  I will probably write one up sometime this weekend.
>
>
> On Sat, Jul 18, 2009 at 7:16 AM, Alejandro Wainzinger <
> aikawarazuni@gmail.com> wrote:
>
>> https://bugs.kde.org/show_bug.cgi?id=192851
>>
>>
>> Alejandro Wainzinger <aikawarazuni@gmail.com> changed:
>>
>>           What    |Removed                     |Added
>>
>> ----------------------------------------------------------------------------
>>              Status|RESOLVED                    |REOPENED
>>         Resolution|FIXED                       |
>>
>>
>>
>>
>> --- Comment #8 from Alejandro Wainzinger <aikawarazuni gmail com>
>>  2009-07-18 13:16:00 ---
>> Well I did visit the link, during work, but I admit I just skimmed it
>> quickly.
>> Since you seem passionate about the topic, why not write up a patch and
>> send it
>> in?
>>
>> --
>> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
>> ------- You are receiving this mail because: -------
>> You are a voter for the bug.
>> You reported the bug.
>>
>
>
Comment 11 Zee Jones 2009-07-19 01:55:20 UTC
This fixes things for me at least.  m4a files now happyly transfer to my iPod, although there is some issues with the covers. But that's another bug.

Thanks!
Comment 12 Rashad Tatum 2009-07-20 02:29:55 UTC
I am going to create another bug report for aiff.  I plan to attach my patch
I just created to the new bug report.

Alexander, I apologize for the way I commented on your remarks regarding the
link I emailed.



On Sun, Jul 19, 2009 at 4:26 AM, Myriam Schweingruber <
kde@pharma-traduction.ch> wrote:

> https://bugs.kde.org/show_bug.cgi?id=192851
>
>
> Myriam Schweingruber <kde@pharma-traduction.ch> changed:
>
>           What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>             Version|2.1-SVN                     |2.2-SVN
>   Target Milestone|---                         |2.2
>
>
>
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are a voter for the bug.
> You reported the bug.
>
Comment 13 Alejandro Wainzinger 2009-07-20 12:07:13 UTC
Marking as fixed, since it seems to be basic.  Will test later.
Comment 14 Tyler Mandry 2009-07-21 21:47:18 UTC
Created attachment 35522 [details]
2.1.1 Patch - Add mp4 to ipod accepted formats

Here's a patch for the 2.1.1 code if anyone needs it.
Comment 15 Rashad Tatum 2009-07-21 22:58:51 UTC
AIFF should be included as a supported format as it has been supported by
every iPod.

On Tue, Jul 21, 2009 at 3:47 PM, Tyler Mandry <tmandry@gmail.com> wrote:

> https://bugs.kde.org/show_bug.cgi?id=192851
>
>
>
>
>
> --- Comment #14 from Tyler Mandry <tmandry gmail com>  2009-07-21 21:47:18
> ---
> Created an attachment (id=35522)
>  --> (http://bugs.kde.org/attachment.cgi?id=35522)
> 2.1.1 Patch - Add mp4 to ipod accepted formats
>
> Here's a patch for the 2.1.1 code if anyone needs it.
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are a voter for the bug.
> You reported the bug.
>
Comment 16 Jan Essert 2009-07-27 10:33:26 UTC
Please do also add .m4b files. These are the same as .m4a files and can hence also be played by any ipod.
The only difference is the extension, which is used by the ipod to distinguish between music and audio books.