Bug 192816

Summary:	Toolbar config ignored in KMail
Product:	[Unmaintained] kmail	Reporter:	Michal Ziabkowski <mziab>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED UNMAINTAINED
Severity:	normal	CC:	thierry.chich
Priority:	NOR
Version:	1.11.90
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Michal Ziabkowski 2009-05-15 20:06:21 UTC

Version:           1.11.90 (using 4.2.85 (KDE 4.2.85 (KDE 4.3 Beta1)), Gentoo)
Compiler:          i686-pc-linux-gnu-gcc
OS:                Linux (i686) release 2.6.29-gentoo-r3

After upgrading from KDE 4.2.3 to 4.2.85, I've noticed that my main toolbar config in KMail seems to have been reset, so I ventured to customize it. This is when I noticed that editing the toolbar accomplishes nothing. I tried moving some buttons, adding new ones, to no avail. It seems that the toolbar falls back to the default config. Its state doesn't reflect what's shown in Configure toolbars. This regression seems to affect every toolbar in the program. Reproduced it with the main toolbar and the compose window, at any rate.

Qt: 4.5.1
KDE: 4.2.85 (KDE 4.2.85 (KDE 4.3 Beta1))

Comment 1 Michal Ziabkowski 2009-05-16 13:16:10 UTC

Okay, I'm closer to finding the actual problem.

The kmmainwin.rc packaged with kdepim-4.2.85 has kpartgui version="414". The one in ~/.kde has kpartgui version="410". So what happens is that KMail ignores the older custom toolbar config in favour of the new, default one. The exact same thing happens with other KMail toolbar files. Manually bumping the versions in the ~/.kde files helps.

However, I see at least two problems with the current behaviour:
1) While the toolbars themselves fall back to pre-packaged defaults, in the "Configure toolbars" dialog my toolbar config is displayed. This left me wondering for a while.
2) Re-editing the toolbars doesn't bump the rc version, so KMail will still use the pre-packaged file.

The toolbar dialog should at least bump the version when saving. Or it should be consistent with what's displayed in the toolbar. Ideally, there should be some automatic migration procedure, where the user is asked whether to restore the default toolbar config or just bump the version number.

For now I'll just bump the version numbers myself.

Comment 2 Michal Ziabkowski 2009-05-18 14:35:24 UTC

Actually, I should refile this against kdeui. It seems to be a general bug in how customized toolbars are handled. Noticed the same behaviour in Dolphin and Gwenview.

Comment 3 Martin Koller 2009-09-02 00:36:26 UTC

*** Bug 190800 has been marked as a duplicate of this bug. ***

Comment 4 Laurent Montel 2015-04-12 10:25:36 UTC

Thank you for taking the time to file a bug report.

KMail2 was released in 2011, and the entire code base went through significant changes. We are currently in the process of porting to Qt5 and KF5. It is unlikely that these bugs are still valid in KMail2.

We welcome you to try out KMail 2 with the KDE 4.14 release and give your feedback.