Summary: | Ark crashes when opening ZIP archives | ||
---|---|---|---|
Product: | [Applications] ark | Reporter: | Michal Ziabkowski <mziab> |
Component: | general | Assignee: | Harald Hvaal <metellius> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | andresbajotierra, m.wege, mehulrajput, nt, rakuco |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | A test archive with three zero-byte files |
Description
Michal Ziabkowski
2009-05-15 18:44:05 UTC
Can you try to generate a backtrace? (do you get the DrKonqi window?) Thanks I'm going to try to reproduce it later. Here using: Qt: 4.5.1 (qt-copy 958974) KDE: 4.2.85 (KDE 4.2.85 (KDE 4.3 Beta1)) kdelibs svn rev. 967040 / kdebase svn rev. 967041 kdeutils svn rev. 968429 libzip 0.9 zip 3.0 on ArchLinux i686 - Kernel 2.6.29.2 I could reproduce the crash. Backtrace: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0xb43acb90 (LWP 22275)] 0xb6a67a38 in QProcess::d_func (this=0x0) at io/qprocess.h:184 184 Q_DECLARE_PRIVATE(QProcess) (gdb) bt #0 0xb6a67a38 in QProcess::d_func (this=0x0) at io/qprocess.h:184 #1 0xb6a64ddf in QProcess::terminate (this=0x0) at io/qprocess.cpp:1643 #2 0xb80c4705 in Kerfuffle::CliInterface::failOperation (this=0x95910e8) at /home/kde-devel/kde/src/KDE/kdeutils/ark/kerfuffle/cliinterface.cpp:419 #3 0xb80c4f80 in Kerfuffle::CliInterface::list (this=0x95910e8) at /home/kde-devel/kde/src/KDE/kdeutils/ark/kerfuffle/cliinterface.cpp:73 #4 0xb80b1e55 in Kerfuffle::ListJob::doWork (this=0x95d6a38) at /home/kde-devel/kde/src/KDE/kdeutils/ark/kerfuffle/jobs.cpp:144 #5 0xb80b54b5 in Kerfuffle::ThreadExecution::run (this=0x95db1f8) at /home/kde-devel/kde/src/KDE/kdeutils/ark/kerfuffle/threading.cpp:41 #6 0xb69ca77f in QThreadPrivate::start (arg=0x95db1f8) at thread/qthread_unix.cpp:189 #7 0xb693a4c5 in start_thread () from /lib/libpthread.so.0 #8 0xb6786f9e in clone () from /lib/libc.so.6 Bug 192739 could be related to this. Thanks *** Bug 192739 has been marked as a duplicate of this bug. *** I'm about to commit a fix to this bug. As a workaround, ensure you have the "zipinfo" command in your path. If this application isn't found Ark will crash. (in ArchLinux, this application is inside the "unzip" package) Thanks SVN commit 968443 by darioandres: Check the m_process object before calling the terminate() method. In some situations (when the helper app isn't found), the m_process object is not even created and this will lead to a crash BUG: 192798 M +2 -1 cliinterface.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=968443 Actually, I do have a zipinfo binary. Also, it seems there have been some other changes to cliinterface.cpp since 4.2.85 was tagged. I've backported those to my build. Didn't help. The bug is still there. Mh, so my backtrace was unrelated to your crash Try to get a full backtrace and we will look at it. Thanks I'm having some problems with building a proper debug build on Gentoo. Not sure why. Anyway, the best info I can get at the moment is: ark(12222)/kio (KDirListerCache) KDirListerCache::forgetDirs: KDirLister(0x8eceff8) item moved into cache: KUrl("file:///tmp") ark(12222)/ark (kdeutils) Kerfuffle::factory: ark(12222)/kdecore (trader) KMimeTypeTrader::query: query for mimeType "application/zip" , "Kerfuffle/Plugin" : returning 2 offers ark(12222)/ark (kdeutils) Kerfuffle::factory: Loading library "kerfuffle_clizip" ark(12222)/ark (kdeutils) Part::setBusyGui: ark(12222)/ark (kdeutils) Kerfuffle::ThreadExecution::run: Run ark(12222)/ark (kdeutils) Kerfuffle::CliInterface::createProcess: ark(12222)/ark (kdeutils) Kerfuffle::CliInterface::executeProcess: Executing "/usr/bin/unzip" ("-l", "-v", "/tmp/1.zip") ASSERT failure in QList<T>::operator[]: "index out of range", file /usr/include/qt4/QtCore/qlist.h, line 403 KCrash: crashing... crashRecursionCounter = 2 KCrash: Application Name = ark path = <unknown> pid = 12222 I'll see if I can fix the problem I'm having. Something awry with the ebuilds from Gentoo's kde-testing, I think. Will look into this. Some more info about the packages I have installed: ZipInfo 2.42 of 28 February 2005, by Greg Roelofs and the Info-ZIP group. Zip 2.32 (June 19th 2006) UnZip 5.52 of 28 February 2005, by Info-ZIP. Could you append a test zip file ? Thanks. I wonder if this could be related to locales... Thanks Created attachment 33697 [details]
A test archive with three zero-byte files
Works for me here... let's wait for Harald to investigate. Sorry about mixing different crashes :\ (In reply to comment #7) > Actually, I do have a zipinfo binary. Also, it seems there have been some other > changes to cliinterface.cpp since 4.2.85 was tagged. I've backported those to > my build. Didn't help. The bug is still there. Did you backport only the changes to cliinterface.cpp? IIRC there have been some changes to clizipplugin itself too. If possible, could you try trunk or backport all the changes? Right, I was cherry-picking the fixes. Just tried backporting the bulk of commits to Ark since 4.2.85 and I can confirm the bug is no more :) Thanks. *** Bug 193536 has been marked as a duplicate of this bug. *** *** Bug 194443 has been marked as a duplicate of this bug. *** |