Bug 192508

Summary: Clear up default nicklist icon theme confusion
Product: [Applications] konversation Reporter: Eike Hein <hein>
Component: generalAssignee: Konversation Bugs <konversation-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: Git   
Target Milestone: ---   
Platform: Unlisted Binaries   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Bug Depends on:    
Bug Blocks: 187307    

Description Eike Hein 2009-05-13 00:04:55 UTC 
SVN revision 919302 introduced a hacky way to make the Oxygen nickname list icon theme the default, by modifying the default value of the preference in konversation.kcfg. There are some problems with this:

- It makes fact that the old default theme still gets installed to the "default" folder somewhat confusing.

- The theme loading code in the Images class falls back to "default" when the theme specified in the configuration file can't be successfully loaded. This means rather than falling back to the new elected default - the Oxygen theme -, it currently falls back to the old default theme.

The old default theme should be installed to "simplistic" instead (the name of the theme), and the Oxygen theme should then be installed to "default".

Existing Konversation installations with "oxygen" in their preferences file would then fall back to "default", which happens to be the Oxygen theme anyway.
Comment 1 Eike Hein 2009-05-13 20:30:30 UTC 
SVN commit 967678 by hein:

Clean up default nicklist icon theme confusion.
BUG:192508


 A             default (directory)   oxygen#967675
 D             oxygen (directory)  


WebSVN link: http://websvn.kde.org/?view=rev&revision=967678
Comment 2 Eike Hein 2009-05-13 21:21:14 UTC 
SVN commit 967708 by hein:

Didn't do quite enough.
BUG:192508


 M  +1 -1      default/CMakeLists.txt  
 M  +1 -1      simplistic/CMakeLists.txt  


WebSVN link: http://websvn.kde.org/?view=rev&revision=967708