Summary: | [BiDi/Unicode] Hebrew selection not showing when dynamic word wrap is disabled | ||
---|---|---|---|
Product: | [Applications] kate | Reporter: | Dotan Cohen <kde-2011.08> |
Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
Status: | RESOLVED WORKSFORME | ||
Severity: | normal | CC: | christoph, ilmari.lauhakangas, justin.zobel, kde-2011.08, mskco.tp, orgads, sh.yaron, shlomif, uhhadd, waqar.17a |
Priority: | HI | Keywords: | rtl |
Version: | 16.04.1 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Unspecified | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: |
Screenshot showing unselected English and Hebrew text
Screenshot showing selected English and Hebrew text The state when word wrap is on Selection is correct here Word wrap is turned off Here the bug shows It's impossible to select part of the RTL text Some UTF text to be used as sample |
Description
Dotan Cohen
2009-05-12 18:16:56 UTC
Created attachment 33587 [details]
Screenshot showing unselected English and Hebrew text
Created attachment 33588 [details]
Screenshot showing selected English and Hebrew text
It looks like the 2 hebrew lines are being recognised by kate's renderer as RTL lines, but being drawn by the Qt text layout system as LTR; then, kate draws the end of line selection background over them. Figuring out why kate thinks differently to Qt will be key for this bug. Works fine for me on KDE-4.3.85 (4.4-beta2) on Mandriva Linux Cooker:
<<<<<<<<
Kate
Version 3.3.85
Using KDE Development Platform 4.3.85 (KDE 4.3.85 (KDE 4.4 Beta2))
>>>>>>>>
I can try on VMs contains different KDE versions.
On debian with 4.4.3, it still doesn't work... @Orgad and Dotan: Can you please build the current Kate from gitorious? Here is a simple step-by-step tutorial: http://gitorious.org/kate/pages/Building%20Kate Please tell us then whether it already works. If not, it would be most awesome if you can provide a patch, since we developers do not use or maybe even understand hebrew text :) Thanks in advance! I can try (can't promise when :)). I just want to mention the problem is not only in kate, but also in kwrite... (In reply to comment #6) > @Orgad and Dotan: Can you please build the current Kate from gitorious? Here is > a simple step-by-step tutorial: http://gitorious.org/kate/pages/Building%20Kate > > Please tell us then whether it already works. If not, it would be most awesome > if you can provide a patch, since we developers do not use or maybe even > understand hebrew text :) Thanks in advance! I should note that I cannot even reproduce this problem here on Mandriva Linux Cooker, and the text selection shows the Hebrew text fine. I can also try that on my Debian Testing VM, and on other VMs, but it may be an Ubuntu-only bug. (Note I speak Hebrew). I should note that you don't need to be intimately familiar with Hebrew to work on this bug, because like Dotan showed the letters simply disappear. I'm not using ubuntu, but debian testing (with kde 4.4.3 packages from sid). (In reply to comment #9) > I'm not using ubuntu, but debian testing (with kde 4.4.3 packages from sid). Hi! Now I can reproduce it on my Debian Testing VM too. Thanks for the heads up. But it's still OK on Mandriva Cooker. It is still reproducible in 4.4.4. I've noticed it only occurs if Dynamic Word Wrap is disabled... Any news? (In reply to comment #12) > Any news? Hi Orgad, maybe the workaround I found for it and mentioned here will work for you: http://shlomif-tech.livejournal.com/58200.html At least in regards to aligning the Hebrew to the right of the screen. Regards, -- Shlomi Fish Thanks! Read my last comment (#11)... :) If you want to look into this issue: http://kate-editor.org/get-it/ The relevant code piece is probably in the renderer... I can still reproduce this bug in KDE 4.7.4. I can confirm the fact that the bug only appears if Dynamic Word Wrap is disabled. I guess it is still in KDE 4.8 and 4.9, or? Could somebody with more knowledge look at this? (In reply to comment #17) > I guess it is still in KDE 4.8 and 4.9, or? > Could somebody with more knowledge look at this? Yes, I can still reproduce this problem in kate-4.9.2-1.mga3 on KDE-4.9.2 on Mageia Linux Cauldron. Created attachment 74975 [details]
The state when word wrap is on
Created attachment 74976 [details]
Selection is correct here
Created attachment 74977 [details]
Word wrap is turned off
Created attachment 74978 [details]
Here the bug shows
Created attachment 74979 [details]
It's impossible to select part of the RTL text
Could you attach the text from the pictures as UTF-8 txt file, too? ;) Just to have it for reference. Thanks a lot for the detailed description, still not sure how to fix that, anybody some ideas? I can confirm this bug exists in KDE 4.9.2 on Archlinux. I also tested it with Persian language and it seems the problem exists only when word wrap is off and the whole line of RTL text is selected. It is also weird that when you start selecting from an LTR text, you can't leave in the middle of the RTL line and the whole line gets selected. The text was just some random mixed RTL and LTR text and I got it deleted. However I will submit another sample. Created attachment 74980 [details]
Some UTF text to be used as sample
Not reproduced with either word wrap on or off. Please re-test. Arch Linux 64-bit Kate 16.04.1 KDE Frameworks 5.22.0 Qt 5.6.0 xcb wm Still reproducable here, when dynamic word wrap is off: * Debian sid amd64 * Kate 16.04.1 * KDE Frameworks 5.22.0 * Qt 5.5.1 * The xcb windowing system (In reply to Orgad Shaneh from comment #28) > Still reproducable here, when dynamic word wrap is off: > > * Debian sid amd64 > * Kate 16.04.1 > * KDE Frameworks 5.22.0 > * Qt 5.5.1 > * The xcb windowing system Looks like our only difference is Qt version :) Maybe re-test again after Qt 5.6 hits Debian sid. (In reply to Orgad Shaneh from comment #28) > Still reproducable here, when dynamic word wrap is off: > > * Debian sid amd64 > * Kate 16.04.1 > * KDE Frameworks 5.22.0 > * Qt 5.5.1 > * The xcb windowing system Still reproducible here, when dynamic word wrap is off: * Mageia Linux v6 x86-64 * kate-16.04.1-1.mga6 * Qt 5.6.0. Qt 5.6.1 is here, and the bug still exists... Yes, still happens :/ Is someone able to please confirm this is still an issue with Qt 5.14 or above? Hi Justin! (In reply to Justin Zobel from comment #33) > Is someone able to please confirm this is still an issue with Qt 5.14 or > above? The problem still happens with Qt 5.15.1 on mageia linux v8 x86-64. There were some changes to the selection behaviour recently, and with the latest master I can't reproduce this anymore. Can't reproduce either anymore. Likely fixed? |