Bug 192431

Summary: Wrong flags of some countries in translatoid.
Product: [Unmaintained] plasma4 Reporter: Zdeněk Zikán <zdenek.zikan>
Component: widget-miscAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: annma, aseigo
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Wrong flags

Description Zdeněk Zikán 2009-05-12 14:01:09 UTC
Version:           0.6.1 (using KDE 4.2.3)
OS:                Linux
Installed from:    Ubuntu Packages

In translatoid plasma widget, I can click the flag to choose languages of translation. In the list of countries, flags for Swedish, Croatian and Vietnamese are wrong. See attached screenshot.
Comment 1 Zdeněk Zikán 2009-05-12 14:02:41 UTC
Created attachment 33575 [details]
Wrong flags

swedish, serbian, vietnamese
Comment 2 Zdeněk Zikán 2009-05-12 14:03:32 UTC
Sorry, I meant serbian, not croatian. :-)
Comment 3 Zdeněk Zikán 2009-05-12 14:06:30 UTC
And one more sorry ... I filed it under Translator Plugin for Kopete, which is wrong. Can somebody change it to something plasma- or artwork-related? I couldn't find Translator plasma applet in the list of applications so I thought this "Translator Plugin" might be the one, which turned out not to be true. :-)
Comment 4 Anne-Marie Mahfouf 2009-05-12 14:15:03 UTC
Serbian flag was fixed 11 days ago, see
http://websvn.kde.org/trunk/playground/base/plasma/applets/translatoid/kbflags/sr.png?view=log

Can you give me links for correct Swedish and Vietnamese flags so I can change them? That would help dealing with this quickly, many thanks in advance,

Anne-Marie
Comment 5 Anne-Marie Mahfouf 2009-05-18 15:22:23 UTC
SVN commit 969537 by annma:

replace with accurate flags (though they have a black border around them if someone find better, feel free to improve)
BUG=192431


 M             sv.png  
 M             vi.png  


WebSVN link: http://websvn.kde.org/?view=rev&revision=969537
Comment 6 Anne-Marie Mahfouf 2009-05-18 16:34:27 UTC
SVN commit 969605 by annma:

revert previous as it was all wrong. The flags themselves are OK but the code is not as in some cases the language code does not match the country code and the code mixes the 2.
Sacha, can you have a look?
CCMAIL=istdasklar@gmail.com
CCBUG=192431


 M             sv.png  
 M             vi.png  


WebSVN link: http://websvn.kde.org/?view=rev&revision=969605
Comment 7 Anne-Marie Mahfouf 2009-05-18 16:49:07 UTC
Example of the bug: Vietnam
Country ISO code: vn
Language code: vi

=> it should take the flag from vn  while it takes it from vi (Virgin Islands)
Comment 8 Anne-Marie Mahfouf 2009-05-18 17:13:48 UTC
Proper fix (forgot to CCBUG)
http://websvn.kde.org/?view=rev&revision=969609
Comment 9 Anne-Marie Mahfouf 2009-05-18 18:22:24 UTC
SVN commit 969638 by annma:

fix Serbian flag wrongly changed 2 weeks ago
This should close 192431
BUG=192431


 AM            kbflags/rs.png  
 M             kbflags/sr.png  
 M  +1 -1      languagemodel.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=969638
Comment 10 Zdeněk Zikán 2009-07-05 23:42:35 UTC
Just updated to KDE 4.3 RC1 (Ubuntu) and the flags are still wrong.
Comment 11 Aaron J. Seigo 2009-07-06 05:30:17 UTC
the applet is still in playground, so it wouldn't have come as part of the rc1 packages.

annma: should this plasmoid be moved out into addons for 4.4?
Comment 12 Anne-Marie Mahfouf 2009-07-06 09:16:18 UTC
Yes, it's pretty finished and working nicely.
It's a "Ship it" from me!
Comment 13 Zdeněk Zikán 2009-07-06 09:49:19 UTC
It's a pity that it didn't make it's way to 4.3 earlier. All right, I'll close the bug when 4.4 comes out.
Comment 14 Aaron J. Seigo 2009-07-06 23:18:40 UTC
looking at the code, i see it uses QHttp. that will need to be addressed before it came come over ....