Bug 192017

Summary:	K3bsetup2 always has changes even if none are made
Product:	[Applications] k3b	Reporter:	Ben Cooksley <bcooksley>
Component:	K3bSetup	Assignee:	Michał Małek <michalm>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version:	Git
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Ben Cooksley 2009-05-08 11:53:38 UTC

Version:            (using Devel)
Compiler:          g++ (SUSE Linux) 4.3.2 [gcc-4_3-branch revision 141291]
 openSUSE 11.1 with default suse permissions
OS:                Linux
Installed from:    Compiled sources

When opening the K3b Setup module in System Settings on a recent ( SVN revision 964656 ) build the K3b setup module claims that it has "unsaved" changes even when none were made, and pressing the "Reset" button has no effect.

Modules should not make changes automatically, and should always offer the user the option to revert their changes through either Defaults or Reset ( neither of which had any effect, or made any apparent changes )

Comment 1 Michał Małek 2009-09-08 22:08:06 UTC

This was done on purpose, so I have changed severity of this bug to "wish".

Comment 2 Michał Małek 2009-10-11 08:49:36 UTC

SVN commit 1033799 by mmalek:

* Don't check automatically programs and devices whose permissions need to be changed. KCM modules should not be marked as "changed" by default.
* Don't display check indicators for programs/devices with correct permissions
* Don't display "Successfully updated all permissions" message at the end - no message is a good message
BUG: 192017

 M  +1 -9      k3bsetup.cpp  
 M  +36 -20    k3bsetupdevicesmodel.cpp  
 M  +33 -18    k3bsetupprogramsmodel.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1033799