| Summary: | page view cannot handle a lot of pages (max widget size) | ||
|---|---|---|---|
| Product: | [Applications] okular | Reporter: | Francesco Riosa <vivo75+kde> |
| Component: | general | Assignee: | Okular developers <okular-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Francesco Riosa
2009-05-07 00:16:11 UTC
SVN commit 964588 by pino: do not hardcode the maximum number of digits of the pages line edit to 4 actually, do not hardcode it at all, as the validator will do the job just fine CCBUG: 191859 M +0 -1 minibar.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=964588 SVN commit 964592 by pino: backport: do not hardcode the maximum number of digits of the pages line edit to 4 actually, do not hardcode it at all, as the validator will do the job just fine CCBUG: 191859 M +0 -1 minibar.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=964592 > 1) the page-counter show only the first 4 ciphers
>
> 2) with page zoom (1 page on monitor)
> - it show only a little piece of page 10370, the counter show 1036
Page line edit fixed for KDE 4.2.4 (and greater).
The other issues are caused by the very same cause: the internal widget used for showing the contents has a maximum size that most of the page layouts for this document can exceed. Updating the title to reflect this.
The proper fix would be not using a widget but painting directly on the viewport. Not trivial, so it won't be in KDE 4.3 (too much risk of breaking the page view at this point).
(... and forgot to confirm it.) Used the patch atop of okular in 4.2.71, it work fine. Great answer time Pino, looking for the Guinness? Thanks SVN commit 989285 by pino: Convert the PageView from a QScrollArea + inner QWidget to a QAbstractScrollArea. - added few utility functions to compensate the miss of a "central scrolled widget", as now we just fully handle (events & painting) the viewport of the scroll area - manually scroll the overlay widgets (form widgets and video widgets) when the "area" is scrolled All the page view functionalities should be working as usual, hopefully I should have ported everything (in case it will be fixed later). Given that now the size page view is no more constrained by the maximum size of a QWidget (which is two orders of magnitude less than the size of an int), we can handle documents with really many pages (10k+) with hopefully no issues. BUG: 191859 As a side effect of the QScrollArea -> QAbstractScrollArea porting, it seems that there are no more drawing glitches when in right-to-left mode. BUG: 192636 M +1 -1 part.cpp M +180 -158 ui/pageview.cpp M +16 -10 ui/pageview.h M +6 -4 ui/pageviewannotator.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=989285 |