Summary: | kioslave/file/file_unix.cpp does not compile on opensolaris | ||
---|---|---|---|
Product: | [Frameworks and Libraries] kdelibs | Reporter: | tropikhajma <tropikhajma> |
Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | annma, faure, t.hirsch |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Solaris | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | since Solaris doesn't have a d_type, we need this patch |
Description
tropikhajma
2009-05-04 01:29:05 UTC
Shouldn't this be sent to https://mail.kde.org/mailman/listinfo/kde-solaris instead for a quick fix and pointers? Also see http://www.opensolaris.org/os/project/kde/ and ask here. Then please attach any patch to this bug report if needed. Created attachment 37386 [details]
since Solaris doesn't have a d_type, we need this patch
@hajma: It's based on your patch. (http://opensolaris.org/jive/thread.jspa?threadID=101870&tstart=45) @dfaure: I've added you to CC, because you were the last one to change this file. I'll also send you another patch I've written yesterday, which is also needed for Solaris. I don't like platform-specific ifdefs, they don't solve the problem the right way (what if solaris gets DT_DIR later; what about other systems that might be missing DT_DIR, etc). Better have a proper configure check for the missing stuff. In this case, it turns out that the check already exists: kdecore/kernel/kstandarddirs.cpp uses #ifdef HAVE_DIRENT_D_TYPE, and this seems to work for you, otherwise your compilation would have stopped there first ;) I'll use it in kio_file. SVN commit 1048732 by dfaure: Fix compilation on systems without d_type/DT_DIR, like Solaris BUG: 191544 M +15 -1 file_unix.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1048732 |