Bug 191420

Summary:	[PATCH] KatePart offers no context menu when embedded in Konqueror
Product:	[Applications] kate	Reporter:	Stephan Sokolow <kde_bugzilla_2>
Component:	general	Assignee:	KWrite Developers <kwrite-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	adawit, christoph, flying-sheep, jmillan, kde-2011.08, oleg.sev
Priority:	NOR
Version:	Git
Target Milestone:	---
Platform:	Compiled Sources
OS:	Unspecified
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Patch KatePart patch

Description Stephan Sokolow 2009-05-03 06:52:07 UTC

Version:            (using KDE 4.2.2)
Installed from:    Compiled From Sources

When embedded in Konqueror, right-clicking KatePart has no effect at all. It should at least display the minimal context menu offered by KWrite.

Comment 1 Andreas Pakulat 2009-05-03 10:32:51 UTC

this is a bug in konqueror, it needs to enable the context menu with the KTextEditor::View API (setContextMenu and defaultContextMenu). Katepart doesn't set a default context menu so the application that embeds it can better customize that context menu.

Comment 2 José Millán Soto 2009-05-09 23:05:45 UTC

Created attachment 33500 [details]
Patch

This patch enables context menu when Katepart is embedded in konqueror.
However, I'm not sure whether this is the best solution or maybe it's a better idea making Katepart context menu enabled by default.

Comment 3 Stephan Sokolow 2009-05-10 00:28:07 UTC

Generally, doing the intuitive thing is just as good for APIs as for GUIs. I think it'd probably be best to default to having a menu as long as it's possible to provide a gotcha-free to set a custom one afterwards.

Comment 4 José Millán Soto 2009-05-12 17:10:52 UTC

Created attachment 33584 [details]
KatePart patch

This patch makes KatePart to have a default context menu set if KateDocument is created in single view mode (which is what happens in when it's created by konqueror and other apps like ark).

Comment 5 Oleg Sevostyanov 2009-06-16 17:24:18 UTC

Confirm that menu doesn't show in KDE 4.2.4 (installed one week ago).

Comment 6 Philipp A. 2009-08-20 17:10:32 UTC

doesn’t show, patch is provided, what are you waiting for?

Comment 7 Dawit Alemayehu 2012-11-17 17:05:15 UTC

Sorry, but this is not a Konqueror bug! Konqueror can embed all sorts parts and there is no way it is going to have code that forces it to link to a specific KPart component. That makes no sense. It is upto the katepart to display the context menu it chooses to show. There is nothing stopping it from allowing embedding application to customize the context menu while providing a minimal set of context menu items by default.

Comment 8 Christoph Cullmann 2013-04-07 10:10:15 UTC

*** Bug 237969 has been marked as a duplicate of this bug. ***

Comment 9 Dominik Haumann 2013-08-14 10:06:48 UTC

Christoph, are there arguments against the proposed patch?
http://bugsfiles.kde.org/attachment.cgi?id=33584

Or should this only be performed when Kate is loaded as brower part?

Comment 10 Christoph Cullmann 2014-09-08 13:45:54 UTC

Git commit ca2fa3331266ccc5841ee8cd0e5ec7603778bddf by Christoph Cullmann.
Committed on 08/09/2014 at 13:44.
Pushed by cullmann into branch 'master'.

fix missing context menu for normal part
applied and extended the patch from the bugreport, should work now
BUG: 33584

M  +2    -1    src/document/katedocument.cpp

http://commits.kde.org/ktexteditor/ca2fa3331266ccc5841ee8cd0e5ec7603778bddf