| Summary: | WebKit part crashes when createNewWindow signal is not connected | ||
|---|---|---|---|
| Product: | [Unmaintained] kdelibs | Reporter: | Paweł Prażak <kojot350> |
| Component: | kdewebkit | Assignee: | webkit-devel |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
SVN commit 962657 by uwolfer: Prevent crash when part is null. Patch by Paweł Prażak, thanks. BUG:191361 M +5 -1 webpage.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=962657 [Comment from a bug triager] Moving old kdewebkit bug reports to kdelibs/kdewebkit. Sorry about the noise |
Version: (using Devel) Compiler: gcc (SUSE Linux) 4.3.2 [gcc-4_3-branch revision 141291] OS: Linux Installed from: Compiled sources When createNewWindow signal is not connected WebKit part crashes (in debugging code). I know that browser should connect this signal to work properly, but part should not crash as well. this is a very simple patch Index: part/webpage.cpp =================================================================== --- part/webpage.cpp (revision 961330) +++ part/webpage.cpp (working copy) @@ -80,7 +80,10 @@ KParts::WindowArgs(), &part); WebKitPart *webKitPart = qobject_cast<WebKitPart*>(part); if (!webKitPart) { - kDebug() << "got NOT a WebKitPart but a" << part->metaObject()->className(); + if (part) + kDebug() << "got NOT a WebKitPart but a" << part->metaObject()->className(); + else + kDebug() << "part is null"; return 0; } return webKitPart->view()->page();