Bug 191359

Summary:	Shadows around thumbnails not consistent with other KDE apps
Product:	[Applications] digikam	Reporter:	Médéric Boquien <mboquien>
Component:	Thumbs-Engine	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED INTENTIONAL
Severity:	normal	CC:	caulier.gilles, marcel.wiesweg
Priority:	NOR	Flags:	mikmach: Junior_Jobs+
Version:	0.10.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	7.6.0

Description Médéric Boquien 2009-05-02 17:24:00 UTC

Version:            (using KDE 4.2.2)
OS:                Linux
Installed from:    Compiled From Sources

Hello,

The shadows around thumbnails are not consistent with the shadows in other KDE apps. For instance in dolphin, activate the icon view mode and the previews. Shadows are displayed with a north-west light source. It is an extremely minor point but it would better to have all KDE apps consistent in this regard.

Thanks.

Comment 1 caulier.gilles 2009-05-02 17:27:29 UTC

And about Gwenview ? Because digiKam use same code than GWenview to render thumb border. This want mean that GWenview is also different than Dolphin ?

Gilles Caulier

Comment 2 Médéric Boquien 2009-05-02 17:49:42 UTC

Hi Gilles,

I have reported the same problem for Gwenview: bug #191362. I have been told by a dolphin developer that dolphin uses kdelibs to get the shadows via KFilePreviewGenerator, that's why i report the bug against gwenview and digikam. It would look more consistent if gwenview/digikam had shadows similar to what kdelibs produces.

Thanks

Comment 3 caulier.gilles 2009-05-02 17:54:49 UTC

digiKam (and GWenview i think) do not use KFilePreviewGenerator, because it lack a lots of file formats to preview.

Marcel, currently rewrite digiKam icon view with Qt4 Model View. This little adjustement can be done in new implementation. Border around icon is just few lines of code...

Gilles

Comment 4 Marcel Wiesweg 2009-05-03 17:18:26 UTC

The code is here: http://websvn.kde.org/branches/KDE/4.2/kdelibs/kfile/kfilepreviewgenerator.cpp

The author is Peter Penz, so it's indeed originating from Dolphin.
In fact it's just completely different drawing code. There is no problem taking this code and using it in the ImageDelegate class. It's a matter of taste.

Comment 5 caulier.gilles 2013-11-25 17:01:02 UTC

Marcel,

Following Qt4 model/view port of icon view introduced with 2.x serie, this file still valid ?

Gilles Caulier

Comment 6 Marcel Wiesweg 2013-11-25 18:20:58 UTC

I did not change anything in this regard. Now it's 2013 and KDE shadows may have changed again. I dont know.

Comment 7 caulier.gilles 2013-11-25 22:33:04 UTC

Thanks Marcel,

Well, we have more important stuff to do in digiKam... I close this file as WONTFIX...

Gilles