| Summary: | ktorrent tar missing Messages.sh | ||
|---|---|---|---|
| Product: | [Applications] ktorrent | Reporter: | Jonathan Riddell <jr> |
| Component: | general | Assignee: | Joris Guisson <joris.guisson> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | modax, rdieter |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Jonathan Riddell
2009-04-28 14:18:31 UTC
Messages.sh is stripped out by the release scripts. Lets take a look at the GPL : "The source code for a work means the preferred form of the work for making modifications to it. For an executable work, complete source code means all the source code for all modules it contains, plus any associated interface definition files, plus the scripts used to control compilation and installation of the executable. However, as a special exception, the source code distributed need not include anything that is normally distributed (in either source or binary form) with the major components (compiler, kernel, and so on) of the operating system on which the executable runs, unless that component itself accompanies the executable." So what needs to be included is: "the scripts used to control compilation and installation of the executable" Messages.sh is not needed compile or install ktorrent, so is not necessary to include this. See http://www.fsf.org/licensing/licenses/info/GPLv2.html section 3 for the text quoted above. The tar includes translations, it should include the scripts used to bulid those translations. What's the rationale for removing the Messages.sh file? Messages.sh only generates pot files, it does not build translations, that is done by gettext. The rationale is that you do not need it to compile or use ktorrent. GPL 3 says ' The "Corresponding Source" for a work in object code form means all the source code needed to generate, install, and (for an executable work) run the object code and to modify the work, including scripts to control those activities.' The .po files are included in the tar, they are from a .pot file generated by the Messages.sh file. KDE licence policy requires code be distributed under GPL 2 and 3. Regardless of quoting legal texts though free software means giving your downstreams the ability to do what they want with the code, in our case we don't change any strings but we do expect that freedom. How can you prove that this particular script is used to generate those files? Typically When I create a tarball for a snapshot of dev release, I run a few simple commands to fetch translations from svn and add a few pregenerated CMakeLists.txt files. So am I required to share my .bash_history/.bashrc by GPL? Huh? Because that's what scripty runs to generate the translation template file. You don't need to release your download scripts, that's not the same as generating files from another input. I'll say again though, I'm less interested in the nuances of GPL than of just having complete source code. KTorrent is GPLv2, so I don't care what v3 says : "For an executable work, complete source code means all the source code for all modules it contains, plus any associated interface definition files, plus the scripts used to control compilation and installation of the executable." Is Messages.sh source code ? No Is Messages.sh an associated interface definition ? No Is Messages.sh a script to control compilation ? No Is Messages.sh a script to install ktorrent ? No So it doesn't need to be included. Would it be hard or kill you to be flexible here to satisfy the (valid) concerns of fellow KDE contributors? No > Would it be hard or kill you to be flexible here to satisfy the (valid)
> concerns of fellow KDE contributors? No
It's not hard at all. It's just that it isn't needed according to my understanding of the GPLv2. Further more if somebody is really interested in it, he or she can just download it using the publicly available svn server of KDE.
And if you actually read the GPL (both v2 and v3) it only says you need to include source code and build scripts when distributing in non source form. So it doesn't matter what you consider to be part of the "Corresponding Source", we are not distributing it in non source form.
I've read the GPL yes, and I share Jonathan's opinion that the Messages.sh file in question falls under the scope of "scripts used..." to build starting from the "preferred form" of the work. "it only says you need to include source code and build scripts when distributing in non source form" even worse, you're imposing an extra burden on those that *do* distribute binaries, based on your incomplete source. In my opinion Messages.sh is not part of the source code, so anybody distributing ktorrent in compiled form doesn't need to include it. However, seeing that I'm no expert on the matter, if you can find an expert on the GPL who says it should be included, then I will include it in the next release. Re; experts Jonathan is an active contributor to kde licensing policy, so from my own (biased) POV, his opinion is worth considering as expert in this matter. If you want, we can also raise the issue on the kde-licensing list, https://mail.kde.org/mailman/listinfo/kde-licensing but I'd think you'd get answers similar to what you have here. I'm tired of this discussion, it will be included in the next release. Thank you, much appreciated. |