Summary: | [PATCH] kjs crashes when built with gcc 4.4 without -fno-strict-aliasing | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Bernhard Rosenkraenzer <bero> |
Component: | kjs | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | hephooey_dev |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: |
Fix
Cleanup patch |
Description
Bernhard Rosenkraenzer
2009-04-16 16:45:36 UTC
Created attachment 32873 [details]
Fix
Created attachment 32874 [details]
Cleanup patch
Looking at the file, there's some odd stuff going on outside the aliasing violations -- in C++ code, it doesn't really make sense to support K&R constructs.
Attaching another patch which gets rid of those (to be applied on top of the previous one), but this one isn't required to fix the problem.
I tried the patch and I can confirm that kjs does not crash any more after this patch. SVN commit 960321 by bero: Fix crash when built with gcc 4.4 without -fno-strict-aliasing Details included in the bug report. BUG:189809 M +26 -147 dtoa.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=960321 SVN commit 960767 by kkofler: Fix crash when built with gcc 4.4 without -fno-strict-aliasing Details included in the bug report. CCBUG:189809 (backport revision 960321 by bero from trunk) M +26 -147 dtoa.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=960767 |