Bug 189661

Summary:	Valgrind on Mac hangs on a race-condition
Product:	[Developer tools] valgrind	Reporter:	Nirnimesh <nirnimesh>
Component:	memcheck	Assignee:	Rhys Kidd <rhyskidd>
Status:	RESOLVED WORKSFORME
Severity:	crash	CC:	glider, nirnimesh, njn, rhyskidd, timurrrr
Priority:	NOR
Version:	3.5 SVN
Target Milestone:	---
Platform:	Compiled Sources
OS:	macOS
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Nirnimesh 2009-04-15 00:14:40 UTC

Valgrind is used for memcheck on unit tests in Chromium.
(http://build.chromium.org/buildbot/waterfall/grid#) Valgrind runs fine, except for one test called base_unittests where it either hangs indefinitely.

Since this does not happen every time, Julian thinks this is some sort of race condition in valgrind.

Comment 1 Timur Iskhodzhanov 2009-07-07 16:53:34 UTC

Nirnimesh,
Can you please give us a name of the test?

Comment 2 Alexander Potapenko 2009-07-28 12:12:43 UTC

The comments in $CHROMIUM_DIR/base/data/valgrind/base_unittests.gtest.txt state that the corresponding tests are TimerTest.RepeatingTimer and TimerTest.RepeatingTimer_Cancel. They seem to pass under the current revision of Valgrind used for testing Chromium.

Comment 3 Nirnimesh 2009-07-28 17:48:55 UTC

The two tests -- TimerTest.RepeatingTimer and TimerTest.RepeatingTimer_Cancel are currently disabled when running base_unittests.

Alexander, did you run the test under valgrind without disabling them? They used to hang often but not always. I could enable them to see if recent versions of valgrind treats them with more love.

Comment 4 Alexander Potapenko 2009-07-28 17:53:34 UTC

I did, and got flaky results, too. Sorry for deception.
I'll take a look at these tests to find out if we can reproduce the bug in a simpler way.

Comment 5 Rhys Kidd 2015-07-25 08:07:39 UTC

Any possibility that you'e been able to produce a simpler test case that reproduces the issue?

There's been significant improvements to Valgrind on OS X since this report, so it may well have been resolved in the interim.

Comment 6 Alexander Potapenko 2015-09-02 10:51:08 UTC

Not a chance, sorry.
We've kept Valgrind running on some Mac tests on Chromium, but we haven't done any Valgrind development for several years, as the tool is now being superseded by compiler-based memory error detectors.
Please feel free to close Chromium-related bugs in Valgrind on Mac as non-reproducible.