Bug 189578

Summary:	Wrong days for some holidays some years (libkholidays)
Product:	[Applications] korganizer	Reporter:	jakob.nylin
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bahlgren, christophe
Priority:	NOR
Version First Reported In:	4.2.2
Target Milestone:	---
Platform:	Slackware
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description jakob.nylin 2009-04-14 00:30:38 UTC

Version:            (using KDE 4.2.2)
OS:                Linux
Installed from:    Slackware Packages

Some Swedish holidays (holidays_se) appears on wrong days, for example the "4. Advent" which is 'black "4. Advent" on sunday before 24.12' appears on 24.12 if that date is a Sunday. In all other cases it works as expected.

The problem seems to be related to the word "before" which seems to be treated as <= instead of <

Comment 1 Christophe Marin 2009-04-14 00:46:28 UTC

Bengt, sorry for bothering. Can you review this bug report please ?

Comment 2 Bengt Ahlgren 2009-04-14 09:47:31 UTC

It can be discussed whether "before" should be <= or <, but I won't comment on that.

The swedish 4th Advent can be on Dec 24th at its latest (was so in 2000 and 2006 for example), so with the current meaning of before (<=), the definition "sunday before 24.12" is correct.

(Note that this year's midsummer was/is one day off too - I provided a patch to holiday_se here: https://bugs.kde.org/show_bug.cgi?id=186825)

Bengt

Comment 3 jakob.nylin 2009-04-14 10:13:18 UTC

Ok, I was wrong about Advent, but it was midsummer that made me think that the definition of "before" was wrong. Thanks anyway!

Comment 4 Allen Winter 2009-04-16 00:26:39 UTC

then I'm closing.

Feel free to send us future updates to the holidays files as necessary.