Summary: | [Patch] CMake is blocked by 'Test BINDINGS_RUN_RESULT' | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Frédéric COIFFIER <frederic.coiffier> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ian.monroe, lfranchi, martin.sandsmark, myriam, sascha, tampakrap |
Priority: | NOR | ||
Version: | 2.2.0 | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | convert QtScriptBindings to Qt-only App |
Description
Frédéric COIFFIER
2009-04-11 14:58:18 UTC
So, what's the dealio with this? Ian, got any ideas? Some Google searches show that some people got this kind of error sometime ago, with SVN version. Unfortunately, I don't find how it has been corrected for them. I can perform some tests on my environment if it can help you. Frédéric: any news on this? Not really. I can just confirm the problem with Amarok 2.1 beta 2. I'm trying to understand the problem but I have no knownledge about CMake. It seems that this message : -- Performing Test BINDINGS_RUN_RESULT corresponds to this test : CHECK_CXX_SOURCE_RUNS( "${source}" BINDINGS_RUN_RESULT) Is there someone who know what's doing this line ? If I add : set( BINDINGS_RUN_RESULT 0 ) before the line with CHECK_CXX_SOURCE_RUNS, CMake is no longer blocked. But it says it can't find QtBindings : -- QtBindings not found. run `make bindingstest && ./bindingstest && echo $?` to see what is missing. If it only prints '0' then you're actually fine. (In reply to comment #5) > If I add : > set( BINDINGS_RUN_RESULT 0 ) > before the line with CHECK_CXX_SOURCE_RUNS, CMake is no longer blocked. > > But it says it can't find QtBindings : > -- QtBindings not found. run `make bindingstest && ./bindingstest && echo $?` > to see what is missing. If it only prints '0' then you're actually fine. Frédéric, I think this is more a Gentoo compilation issue than a real Amarok bug. Please refer to our forums or get in touch with us in #amarok on Freenode. I agree. In fact, by adding set( BINDINGS_RUN_RESULT 1 ), QtBindings isn't tested but CMake is no longer blocked and I reach to compile Amarok. So, it's enough for the moment. Actually, you might want to have a look at my investigations at http://bugs.gentoo.org/show_bug.cgi?id=270923 The freeze is a deadlock on a Qt internal mutex in QtDBus while trying to register with the bus. Further i found that the same compiled executable seems to work if run as "normal" user, but doesn't if run as root. However; i see no reason at all to use DBus in that test. What is the use of KApplication (which causes DBus registration) for? Created attachment 38326 [details]
convert QtScriptBindings to Qt-only App
I'm sorry but i have to ask you to reopen this as I have a patch here. As Sput (quassel dev) suggested, QtScriptBindingsTest.cpp could use QApplication instead, so i did it a Qt-app. I hope this is acceptable to you. I guess there is no reason for it to be KDE-app. Thank you.
I presume you are both using version 2.2.0 at least? Theo, please make a merge request on Gitorious, so the devs can review the patch. The above patch is wrong, it should use QCoreApplication. Never mind, here is the merge request [1] the comments of which give all the necessary info. [1] http://gitorious.org/amarok/amarok/merge_requests/2093 merged. |