Summary: | Make clicking on system tray icon more consistent with taskbar | ||
---|---|---|---|
Product: | [Frameworks and Libraries] kdelibs | Reporter: | matsei |
Component: | kdeui | Assignee: | kdelibs bugs <kdelibs-bugs> |
Status: | REPORTED --- | ||
Severity: | wishlist | CC: | matsei |
Priority: | NOR | ||
Version: | 4.2.2 | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
Change behavior when app is shown not minimized on other desktop
Same patch without the typo Same patch with fix for windows shown on all desktops New version of the patch |
Description
matsei
2009-04-05 11:02:07 UTC
Created attachment 32613 [details]
Change behavior when app is shown not minimized on other desktop
Created attachment 32614 [details]
Same patch without the typo
Sorry, wrong patch attached first time, didn't even build ...
This is agains kdelibs-4.2.2 release tarball.
Created attachment 32617 [details]
Same patch with fix for windows shown on all desktops
Previous patch used the cached d->onAllDesktops information to guard against these types of apps, but that was not appropriate.
Created attachment 32620 [details]
New version of the patch
Fix an additional bug with the following sequence:
- start a trayable app
- set "On All Desktops"
- hide to tray by clicking on tray applet
- show app by clicking on tray applet
=> d->onAllDesktops = true, app is visible
- set e.g., "On Desktop 1"
- minimize to taskbar (not to tray)
- click on tray applet
=> mapped == false because info.isMinimized() is true
=> d->onAllDesktops is still == true, nothing has updated that yet
=> minimizeRestore(true) will restore to all desktops...
Fix this by refreshing d->onAllDesktops if window is minimized before doing the restore.
Updated patch available at http://reviewboard.kde.org/r/579/ |