Bug 188676

Summary:	Turning off krfb option "Ask before accepting uninvited connection" has no effect. User still gets asked and needs to accept the vnc connection.
Product:	[Applications] krfb	Reporter:	komputes <komputes>
Component:	general	Assignee:	George Goldberg <grundleborg>
Status:	RESOLVED FIXED
Severity:	normal	CC:	grundleborg, RBredereck
Priority:	HI
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	screenshot of non-working option

Description komputes 2009-04-02 19:15:24 UTC

Version:           4:4.2.1-0ubuntu1 (using KDE 4.2.1)
OS:                Linux
Installed from:    Ubuntu Packages

There always needs to be someone at the computer to accept the VNC connection. The option "Ask before accepting uninvited connection" has no effect. I am testing this on kubuntu 9.04 beta.

Comment 1 komputes 2009-04-02 19:41:05 UTC

Please edit the title to say krfb and not krdc

Comment 2 komputes 2009-04-02 19:44:45 UTC

Created attachment 32545 [details]
screenshot of non-working option

Comment 3 George Goldberg 2009-09-12 12:19:07 UTC

Upping the priority so I remember to fix this one soon.

Comment 4 Robert Bredereck 2009-09-14 22:33:28 UTC

I can confirm this bug in krfb 4.3.1 (using 4:4.3.1-0ubuntu1~jaunty1~ppa5 on Kubuntu 9.10), too.
Note: Krfb is useless for MANY users with this regression/bug!

Comment 5 George Goldberg 2009-09-15 21:37:05 UTC

I think I've finally got my head around what's going on here:

When a new connection comes in, krfb has no way of knowing whether it is invited or not until the remote user has entered the password. However, krfb asks you to accept/reject the connection before remote user gets asked for a password (bug 87523). Whether this is a bug or desirable is up for debate, and at least for now, I'd prefer to stick with the current solution (favouring caution over convenience).

What krfb does instead, is, if there are no outstanding invitations, it assumes this is an uninvited connection, and so, if this option is deselcted, it doesn't ask locally for confirmation. However, if there are oustanding invitations it assumes this will be an invited connection and so asks for local confirmation.

The basic solution to this, would, imho, be to change the option's name to "Ask before accepting connections." and have it apply to both uninvited and invited questions the same.

I'll land a commit for this shortly in trunk.

Comment 6 George Goldberg 2009-09-16 14:25:46 UTC

SVN commit 1024354 by gberg:

Change -Ask before accepting uninvited connections- to just -Ask before accepting connections- and make it behave as expceted.

This is because we can't know until after the connection has been accepted whether it was invited or not, so the old code used the broken method of seeing if there were 0 or more invitations to tell.

BUG: 188676

 M  +30 -29    configsecurity.ui  
 M  +1 -1      connectioncontroller.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1024354