Bug 188263

The problem is in digikam/imagepreviewbar.cpp:200,
we need to check for a null pointer here...

Strange I still can't produce this crash.

Andi

(In reply to comment #1)
> The problem is in digikam/imagepreviewbar.cpp:200,
> we need to check for a null pointer here...
> 
> Strange I still can't produce this crash.
> 
> Andi

I don't know if it's pertinent, just forgotten to say it before, but I enabled that options to make digikam write metadata (keywords, stars, ...) inside each photo.

There are some other issues:

1. Load an image into the editor.
2. Set some rating in the thumbbar
3. DON'T leave the rating widget and set another rating.
4. LEAVE the rating widget now, the first made rating will be shown again (some signal is missing?)

If you open the Caption/Tags sidebar, you can see that a rating is assigned only once. In the main albumUI you can change the rating as often as you like without losing the focus on the star rating widget.
Maybe this is related to the above problem, too?

Andi

(In reply to comment #2)
> I don't know if it's pertinent, just forgotten to say it before, but I enabled
> that options to make digikam write metadata (keywords, stars, ...) inside each
> photo.

I have this enabled, too, but I'm not able to crash digiKam.

(In reply to comment #3)
> There are some other issues:
> 
> 1. Load an image into the editor.
> 2. Set some rating in the thumbbar
> 3. DON'T leave the rating widget and set another rating.
> 4. LEAVE the rating widget now, the first made rating will be shown again (some
> signal is missing?)
> 
> If you open the Caption/Tags sidebar, you can see that a rating is assigned
> only once. In the main albumUI you can change the rating as often as you like
> without losing the focus on the star rating widget.
> Maybe this is related to the above problem, too?

Maybe yes, I tried doing things this way and found the problem you say: when I leave the star widget I get the previous rating.

I also see that the stars seem "garbled", just like there is a second row of stars behind it, when I change the actual rating to an higher one and after to a lower one, without losing the focus, as you said.
I tried these things four or five times, getting one crash, but I can't say what I was doing different that time.

Actually, it crashed every time I change the rating of an image in the thumbnail bar but different from the one loaded in the editor.

I really tried to provoke this crash on my machine, but I'm just unable to succeed. Maybe you can find a pattern that really crashed digiKam all the time and give us a step-by-step TODO list?
Or you might record a video of it, for example with recordmydesktop or such a software.
Chances are that you will not be able to attach the video here, but feel free to send my an email with the file.

Andi

(In reply to comment #6)
> I really tried to provoke this crash on my machine, but I'm just unable to
> succeed. Maybe you can find a pattern that really crashed digiKam all the time
> and give us a step-by-step TODO list?
> Or you might record a video of it, for example with recordmydesktop or such a
> software.

OK, I tried some more, and recorded a screencast with recordmydesktop as you suggested. 
You can download it from my personal web server at this address:
http://gerlos.homelinux.org/data/
It won't download the video directly, it will display you an html page and you can download it from there. If you can't reach the page try in a half a hour, maybe they changed my ip and my dyndns record didn't update...

With some more experiments I saw that my digikam crashed *also* when viewing the preview of an image and changing the rating in the thumbnail bar for an image different from the one displayed.

I don't know if I provided enough information, ask if you need more to understand the problem...

After clicking like crazy on the AbumUI and ThumbBar (over 10 billion times, I swear :-)) I finally managed to crash digiKam:

rogram received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb484e700 (LWP 20293)]
0xb7246ec9 in Digikam::ThumbBarItem::repaint (this=0x0) at /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/widgets/common/thumbbar.cpp:1181
1181        d->view->repaintItem(this);
(gdb) bt
#0  0xb7246ec9 in Digikam::ThumbBarItem::repaint (this=0x0) at /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/widgets/common/thumbbar.cpp:1181
#1  0x08316c35 in Digikam::ImagePreviewBar::rearrangeItems (this=0xa55c028) at /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/digikam/imagepreviewbar.cpp:203
#2  0xb7246da8 in Digikam::ThumbBarView::slotUpdate (this=0xa55c028) at /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/widgets/common/thumbbar.cpp:1033
#3  0xb724c432 in Digikam::ThumbBarView::qt_metacall (this=0xa55c028, _c=QMetaObject::InvokeMetaMethod, _id=3, _a=0xbfd461a8) at /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/digikam/thumbbar.moc:85
#4  0x08317ddc in Digikam::ImagePreviewBar::qt_metacall (this=0xa55c028, _c=QMetaObject::InvokeMetaMethod, _id=53, _a=0xbfd461a8) at /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/digikam/imagepreviewbar.moc:66
#5  0xb59dc1a9 in QMetaObject::activate () from /usr/lib/libQtCore.so.4
#6  0xb59dc752 in QMetaObject::activate () from /usr/lib/libQtCore.so.4
#7  0xb5a13b77 in QTimer::timeout () from /usr/lib/libQtCore.so.4
#8  0xb59e313e in QTimer::timerEvent () from /usr/lib/libQtCore.so.4
#9  0xb59d8f5f in QObject::event () from /usr/lib/libQtCore.so.4
#10 0xb5e3101c in QApplicationPrivate::notify_helper () from /usr/lib/libQtGui.so.4
#11 0xb5e38a9e in QApplication::notify () from /usr/lib/libQtGui.so.4
#12 0xb6845cfd in KApplication::notify () from /usr/lib/libkdeui.so.5
#13 0xb59c9c1b in QCoreApplication::notifyInternal () from /usr/lib/libQtCore.so.4
#14 0xb59f49a1 in ?? () from /usr/lib/libQtCore.so.4
#15 0xbfd469b0 in ?? ()
#16 0x0a6b2688 in ?? ()
#17 0xbfd4663c in ?? ()
#18 0xb6845cfd in KApplication::notify () from /usr/lib/libkdeui.so.5
#19 0xb59f1540 in ?? () from /usr/lib/libQtCore.so.4
#20 0x0a3d8ca4 in ?? ()
#21 0xb51c423c in ?? () from /usr/lib/libglib-2.0.so.0
#22 0xbfd466d8 in ?? ()
#23 0xb51495e8 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
Backtrace stopped: frame did not save the PC


Seems to be some kind of race condition, some items should be drawn but it is already deleted. This really happens when clicking like crazy on the thumbbar.

Andi

This bug is true for AlbumUI and ImageEditor, so I will change the title a little bit...

(In reply to comment #7)
> OK, I tried some more, and recorded a screencast with recordmydesktop as you
> suggested. 
> You can download it from my personal web server at this address:
> http://gerlos.homelinux.org/data/

Thanks for the video and the very detailed description. As I mentioned above, I managed to crash digikam once now, but it was very hard to do and I didn't manage to do it again.
I have an idea about the crash and the strange "duplicate stars" effect, but right now I can't track it down precisely.

Andi

Andi, Gerlos,

What's news about this entry. It still valid ?

Gilles Caulier

Hmm this one is so hard to test, right now I can't reproduce it. But it took me ages before to crash digiKam, so it might be still valid.
Need to check this tomorrow.

Probably my problem belongs to the same category. But additionally, digikam crashes also after a change of the keywords. After restarting digikam, the change of keyword or star rating is still visible --> the crash happens AFTER these changes have been written.
JD

is it still valid on mandriva 2010.0 rpms ?

--- 
Nicolas Lécureuil
Mandriva KDE Team

digiKam 1.0.0 is out since few days...

http://www.digikam.org/drupal/node/491

Please try with this version comming with more than 400 bugfixes. 

Thanks in advance

Gilles Caulier

digiKam 1.0.0 is out since few days...

http://www.digikam.org/drupal/node/491

Please try with this version coming with more than 400 bug-fixes.

Thanks in advance

Gilles Caulier

digiKam 1.1. release will be done in few days. Please check if this entry still valid.

Thanks in advance

Gilles Caulier

digiKam and Kipi-plugins 1.2.0 are out. Please check if crash is still valid there.

Thanks in advance

Gilles Caulier

This bug is still valid with:
digikam 1.1.0-r1
kipi-plugins 0.8.0
libkipi 4.3.5
kernel 2.6.32-gentoo-r7

With my machine, a 7 yr old Athlon XP @2.6GHz, 4GB RAM, it does not need a lot of clicking, just a few changes to the ratings and crash it goes... reliably, each time I try it.
I don't use the thumbnail bar, but rightclick on the picture and select a rating there. No other editing. When using the thumbnailbar the crash occurs even faster.

Thanks for looking into that.

Rgds,
Ekki

ekki,

This bug have been fixed in digiKam 1.2.0.

Gilles Caulier

On Monday 07 June 2010 00:32:22 Gilles Caulier wrote:
> https://bugs.kde.org/show_bug.cgi?id=188263
> 
> 
> 
> 
> 
> --- Comment #20 from Gilles Caulier <caulier gilles gmail com>  2010-06-07
>  00:32:19 --- ekki,
> 
> This bug have been fixed in digiKam 1.2.0.

Ok, great, thanks. Didn't see that. So I will wait until the Gentoo guys get 
it into portage.

Many thanks, it's a great program.
Ekki

Andi,

I think this file can be closed. Right ?

Gilles Caulier