| Summary: | KUrlRequester should replace content on drag&drop | ||
|---|---|---|---|
| Product: | [Unmaintained] kio | Reporter: | Christoph Burgmer <chrislb> |
| Component: | general | Assignee: | David Faure <faure> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | finex, kdelibs-bugs |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Christoph Burgmer
2009-03-26 04:58:48 UTC
... but that's the usual behavior when dropping text. Doesn't konqueror's location bar work just the same? I thought this was the whole purpose of the embedded "clear" button. It does show in KUrlRequester, right? Thanks for the feedback. Well, I can not say that I am pretty confident about my suggestion, but with the usecase given I would say that there is pretty much a usability problem. Now, either the widget, the program or I'm doing it wrong. I agree that droping text will and should insert at the given position, but in my case I was dropping a file. Am I correct in assuming that in general KDE libraries do make a difference between both in drag and drop? Could the widget just distinguish between the object dropped? When dropping a file I would believe nobody is actually trying to manipulate a previously entered string by inserting a absoulute path name, so that "replace" should be the only option. Ah ok, dropping a file, not the copied-URL-of-a-file. Now that makes a lot of sense indeed. I'll have a look at this. It applies to the konqueror location bar too, in fact. Makes me wonder if I should do this for all lineedits, i.e. in KLineEdit. SVN commit 944893 by dfaure: When dropping a URL into a single-url-lineedit like KonqCombo or KUrlRequester, better usability is to replace the current text with the new url, rather than insert/append. BUG: 188129 M +21 -11 klineedit.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=944893 @David: could this be similar to #152126 ? FiNeX: unfortunately not. 152126 is about khtml's event handling, which prevents the KLineEdit code from being called at all. |