Bug 187995

Summary:	Selecting an custom icon for a group switches also an icon for "Select icon" button.
Product:	[Applications] kget	Reporter:	Piotr Pełzowski <pelzowski>
Component:	general	Assignee:	KGet authors <kget>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jgoday
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Piotr Pełzowski 2009-03-24 13:16:37 UTC

Version:            (using KDE 4.2.0)
OS:                MS Windows
Installed from:    MS Windows

Go to 'Kget Settings' >> 'Configure KGet' >> select section 'Groups' >> 

select default group and click "Select icon". Choose any icon and press "Ok"
Selecting an icon switches also an icon for "Select icon" button.

Alternatively add new group, select this new group and click "Select icon". Choose any icon and press "Ok". The same happens here.

screenshot if I didn't managed to describe it properly ;) -> http://img90.imageshack.us/img90/7392/kgeticon420.png

Comment 1 Javier goday 2009-03-28 17:42:48 UTC

This is the current behavior of the KIconButton (http://api.kde.org/4.x-api/kdelibs-apidocs/kio/html/classKIconButton.html) displaying the selected icon in the button.
Maybe we can call resetIcon after changeIcon signal.

Comment 2 Lukas Appelhans 2009-03-28 17:44:30 UTC

I think we should rather use the group's icon for the button from the beginning...

Lukas

Comment 3 Javier goday 2009-03-28 17:52:27 UTC

Hi lukas!

Do you mean use the group icon in the list to raise the select icon dialog and remove the 'select icon' on the bottom of the preferences page
 or
Use always the selected group icon in the 'select icon' button ?

(In reply to comment #2)
> I think we should rather use the group's icon for the button from the
> beginning...
> 
> Lukas

Comment 4 Lukas Appelhans 2009-03-28 17:56:01 UTC

Just set the current group's icon as current icon of the KIconButton... :)

Lukas

PS: I would have fixed that already, but I'm somehow working on something else in KGet at the moment ;)

Comment 5 Lukas Appelhans 2009-04-14 20:04:22 UTC

SVN commit 953905 by lappelhans:

When a group gets selected use the group's icon for the KIconButton
BUG:187995


 M  +1 -0      conf/transfersgroupwidget.cpp  
 M  +6 -1      core/transfergroup.h  
 M  +7 -2      core/transfergrouphandler.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=953905