Bug 187981

Summary: Deleting directories does no longer work in SVN 6248
Product: [Applications] krusader Reporter: René Krell <renda.krell>
Component: generalAssignee: Shie Erlich <manson>
Status: RESOLVED FIXED    
Severity: normal CC: amaguran
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description René Krell 2009-03-24 09:58:26 UTC
Version:           2.0.0-SVN "Mars Pathfinder" (using 4.2.1 (KDE 4.2.1) "release 104", KDE:KDE4:Factory:Desktop / openSUSE_11.1)
Compiler:          gcc
OS:                Linux (i686) release 2.6.27.19-3.2-default

In SVN r6248 there is a problem deleting directories from Krusader. Deleting using rm -rf and Dolphin works fine, this is not a KDE problem.

If I mark one directory it is not deleted at all.
If I mark more than one directory, it deleted almost all dirs, but the first one of the marked directories is not deleted.

As far as I remember, deleting worked reliably in r6244.
Comment 1 René Krell 2009-03-24 17:28:41 UTC
I tried it again in r6244: Delete a directory doesn't work even there.
A self-build with r6249 did not bring any change.
For reproducing: Only non-empty directories are concerned.

Using KDE 4.2.1 with some latest branch diffs and Qt 4.5.
Comment 2 René Krell 2009-03-24 17:50:40 UTC
Compiled r6238, which is the first version known to compile with Qt 4.5.
No change, non-empty directories aren't neither deleted, nor an error message is thrown, regardless whether the directory for deleting contains a file or further subdirectory. Deleting each single file or empty subdirectory with Krusader works, but no recursion.
This should be enough for reproducing.
Comment 3 René Krell 2009-03-24 18:30:04 UTC
I think I got it more detailed, for reproducing:

In a directory of your choice:
- Press F7 and create a directory a/b/c
- Press F8 on a/
- Messagebox appears: "Do you really want to delete this item?" - a
- Press Enter or Click Delete
- Messagebox appears: "Directory a is not empty. Skip this one or delete all"
- Press Arrow right button - "Delete all" button gets focus"
- Press Enter
I would expect the "Delete all" action to be performed, but nothing happens, only the messagebox closes, as if I pressed Cancel.

Second test:
- Press F8 on a/
- Messagebox appears: "Do you really want to delete this item?" - a
- Press Enter or Click Delete
- Messagebox appears: "Directory a is not empty. Skip this one or delete all"
- Press <Space> or click directly on "Delete all"
All works as expected.

There seems to be a focus and button action processing problem in Qt or Krusader.
Comment 4 Alex Maguran 2009-05-12 07:42:19 UTC
I can confirm this bug on ubuntu jaunty - running krusader under gnome.
Comment 5 René Krell 2009-06-04 11:54:56 UTC
This works now for me with:

- KDE 4.2.88 (KDE 4.3 >= 20090527) - OpenSUSE 11.1 KDE4:Factory:Desktop repository

- Qt 4.5.1 - OpenSUSE 11.1 KDE:Qt repository
  Changelog:
  * Sun May 31 14:00:00 2009 dmueller@suse.de
  - add patches:
    * Fix deserialization of values with custom types
    * Make sure syncqt creates the Phonon/Global file.
    * Fix huge memory leak in QPixmapCache
    * Do not deduce scrollbar extent twice
  * Thu Apr 23 14:00:00 2009 beineri@opensuse.org
  - update to 4.5.1:
    * for detailed changelog see included changes-4.5.1

Thanks to the unknown developer who fixed this on the way :-)