| Summary: | Cannot turn off sidebar after Infrared filter usage? | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Joe Biden <mailinglist> |
| Component: | Showfoto-Usability | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, marcel.wiesweg |
| Priority: | NOR | ||
| Version: | 0.10.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 1.0.0 | |
| Sentry Crash Report: | |||
|
Description
Joe Biden
2009-03-20 20:13:56 UTC
I think that this sidebar setting might be shared between the filter and the editor, which is counter-intuitive, because in the filter, you absolutely need the sidebar to set settings, etc. but in the editor proper, you don't want the geolocator on most images just being there. This should probably be per-filter, or even one setting for filters (Don't see how you can use them without a sidebar, since that seems to be how they are built now) and for the editor, which is usable without a sidebar. I have a video showcasing all the problems with this flow and how it needs to change with regard to display and usability bugs. Let me know who would like the link to the video, since it has some images I wouldn't like public. MArcel, I confirm this problem with 0.11 implementation. Why sidebar is re-opened after to use editor tool like Infrared ? I remember that you have fixed something like that before 0.10 final release, or i'm wrong ? Gilles But this behavior is true for every filter, not infrared only. The sidebar will stay open (but at least I'm able to close it again). There is another dysfunction here, we don't need the Try button, because changing the ISO value will toggle the filter anyway. I will remove it... About the main issue: Can't we just save the sidebar state before entering a filter? Andi >About the main issue: Can't we just save the sidebar state before entering a
>filter?
It supposed to be done normally (:=))))
Gilles
There is a problem in line 261f. of sidebar.cpp. We store the size of 0 but setting this fails. Need to try some solutions tomorrow. This code is prone to create side effects and break when changed ;-) I had changed code for thumbnail bar in imagepreviewview that also had problems when storing a size of zero. This isn't valid I guess. So I just saved the whole thumbbar state, which seems to recognize a hidden / collapsed state and therefore can restore the thumbbar in a correct way. So maybe instead of saving a size of zero (I have not looked at the code now), we should simply save the sidebar state... at least it worked fine for my thumbbar problem. Andi SVN commit 955672 by mwiesweg: Do not set previous tab from here. The sidebar will save state on its own. BUG: 187733 M +2 -1 NEWS M +0 -5 utilities/imageeditor/editor/editortooliface.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=955672 |