Summary: | Akregator sometimes does not quit properly if tray icon disabled | ||
---|---|---|---|
Product: | [Applications] akregator | Reporter: | Alec Moskvin <alecm> |
Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED WORKSFORME | ||
Severity: | normal | CC: | florianmerz, haakon, hessijames |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Fix |
Description
Alec Moskvin
2009-03-16 18:36:33 UTC
This is reproducible on trunk. Disable the tray icon, open an article in a new tab, close the window, and you now have a useless akregator process. This is a gdb backtrace from the process in this state: #0 0xb80a2430 in __kernel_vsyscall () #1 0xb5da0167 in poll () from /lib/tls/i686/cmov/libc.so.6 #2 0xb4da2c52 in ?? () from /usr/lib/libglib-2.0.so.0 #3 0xb4da2f81 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0 #4 0xb6c465d8 in QEventDispatcherGlib::processEvents (this=0x9339278, flags={i = -1079372440}) at kernel/qeventdispatcher_glib.cpp:323 #5 0xb6148da5 in QGuiEventDispatcherGlib::processEvents (this=0x9339278, flags={i = -1079372392}) at kernel/qguieventdispatcher_glib.cpp:202 #6 0xb6c1920a in QEventLoop::processEvents (this=0xbfaa1610, flags={i = -1079372328}) at kernel/qeventloop.cpp:149 #7 0xb6c1964a in QEventLoop::exec (this=0xbfaa1610, flags={i = -1079372264}) at kernel/qeventloop.cpp:200 #8 0xb6c1baf9 in QCoreApplication::exec () at kernel/qcoreapplication.cpp:880 #9 0xb60a8a97 in QApplication::exec () at kernel/qapplication.cpp:3553 #10 0x0804efc1 in main (argc=Cannot access memory at address 0xb ) at /home/kde-devel/kde/src/KDE/kdepim/akregator/src/main.cpp:115 MainWindow::queryExit() is called when you close the window, and returns true. The problem is only there in sessions when you have made new tabs. If akregator starts with tabs from previous sessions, there is no problem. Created attachment 32325 [details]
Fix
With this patch, akregator properly exits in the described situation. I'm a newbie and I'm not sure if the patch could have unintended consequences, so please review. Note I had to check for m_part nullness in slotQuit because queryExit is called twice for a reason unknown to me.
This bug also affects Kontact when embedding Akregator. If you open a new Akregator tab and quit Kontact, then there is a kontact process lingering which has to be killed manually. The patch does not fix (or cause) this.
I can confirm this bug. This bug is still present in KDE 4.3.2 Haakon, could you please submit your patch to the Review Board? They usually review/apply them much faster if you put them there rather than on bugzilla. http://reviewboard.kde.org/groups/kdepim/ Thanks! this bug is still valid for kde 4.4.2 I can't reproduce with the steps mentioned by the bug reporter. The 'close' button quits akregator. |