Bug 186864

Summary:	add Body-part playlist layout for Various Artists
Product:	[Applications] amarok	Reporter:	simon
Component:	Playlist	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED DUPLICATE
Severity:	wishlist	CC:	nhn, teo
Priority:	NOR
Version:	2.1-SVN
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	patch

Description simon 2009-03-11 14:44:44 UTC

Version:           2.1-SVN (using 4.2.64 (KDE 4.2.64 (KDE 4.3 >= 20090218)), Gentoo)
Compiler:          x86_64-pc-linux-gnu-gcc
OS:                Linux (x86_64) release 2.6.26-tuxonice

hi,

it would be very usefull to have a extra layout Body part for VA albums in the same way there is a body part for single tracks:

when adding a sampler to the playlist i'd like to put the artist for this track into the playlist layout, so there should be a distinction to the Single Artist albums in the layout editor.

Comment 1 simon 2009-04-03 19:38:40 UTC

Created attachment 32576 [details]
patch

please test

Comment 2 simon 2009-04-03 19:39:17 UTC

a patch that adds a extra Playlist Layout for compilation bodys, allowing to show the track artist in the playlist or other stuff,

please review and give feedback thanks

Comment 3 Nikolaj Hald Nielsen 2009-04-06 08:23:26 UTC

Simon, 

Thanks for your patch. I am not sure I think that this is the right way to solve the issue however, as adding another layout item for a specific "corner" case ( even though you can argue that for many people it is a very common case ) seems too add a lot of complexity for all cases. 

I am thinking a way to overcome this could be to have some elements in a layout be "optional" as in, only show them if they ( or another element ) have a non 0 ( or non empty string ) value, or a value that is different from some other value ( say, only show Artist if AlbumArtist" != Artist and AlbumArtist != "" )

I am not totally sure if this approach is better, but it is something I need to think about. In any case, as we are currently in feature freeze for Amarok 2.1.0 major changes to the playlist layout stuff will have to wait until development of 2.2 opens up.

Comment 4 simon 2009-04-06 13:21:15 UTC

ok i see your points, i also like the idea of enhancing the tokens and add some more logic there like a compilation-aware track+title(+artist) token.

things like

- integration into upcoming playlist sorting 
- variable column width of "variable" tokens
- the easiest way for the user to set it up ( a tab less might be less complicated)

should also be considered.

Comment 5 Myriam Schweingruber 2009-08-27 22:59:31 UTC

Teo, Nikolaj, I guess this can be closed now, right?

Comment 6 Nikolaj Hald Nielsen 2009-08-27 23:05:09 UTC

No, still valid as a wishlist item. I still feel the same about the original patch, but have not yet had time to work on an alternative.

Comment 7 Sven Krohlas 2010-03-25 00:03:54 UTC

Has just been checked in, see:

*** This bug has been marked as a duplicate of bug 219618 ***