| Summary: | please use consistent button labels -- cancel instead of reset | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Maciej Pilichowski <bluedzins> |
| Component: | general | Assignee: | System Settings Bugs <sourtooth+ssbugs> |
| Status: | RESOLVED INTENTIONAL | ||
| Severity: | normal | CC: | andresbajotierra, celeste |
| Priority: | NOR | ||
| Version: | 4.2.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Maciej Pilichowski
2009-02-22 13:27:45 UTC
IMHO, the "Cancel" action would gave me the impression that the "dialog" is gonna be closed when I click on it (same logic -> we use "Apply" instead of "OK"; as the OK button will lead to impression that the whole app is gonna be closed when I commit the changes clicking on it. "Apply" is just commiting changes without closing) About the positioning , as the current SS implementation is using KDialog for the modules pages, I don't know if the Reset button is a standard button (and therefore its position is hardcoded) What do you think ? You are right about the cancel and closing. There are some solutions: a) closing the section (there is no such case, but it can be done) b) making an exception in this case and do not close _window_, because it is not window I opt for (a), the behaviour would be more consistent. With agreement about reset->cancel change, the placement is rather obvious -- it should be consistent with KDE, i.e. next to apply. [ help ] [ default ] [ apply ] [ cancel ] not [ help ] [ default ] [ cancel ] [ apply ] Btw. I didn't mention it, but HIG is not clear 100% about reset label, but it is rather in favor of not using it (label). What if you want to cancel the current changes (returning to the saved config) but without closing the KCModule itself ? May be it can use "Reset" (or "Discard") and "Cancel" (to discard + close module), but that would be too much options. I added Celeste from KDE-Usability to discuss this issue. It won't be closing module, only a section. Right pane would become blank (or with some info). It could be non-closing cancel as well. Reset+cancel would be indeed to many options. Cancel implies that the application will close to the user. Reset implies "Revert my changes" which makes sense in this case. |