Summary: | Advanced search is not saved/restored correctly | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Andi Clemens <andi.clemens> |
Component: | Searches-Advanced | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | caulier.gilles, marcel.wiesweg |
Priority: | NOR | ||
Version: | 0.10.0 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 7.0.0 | |
Attachments: | wrong options |
Description
Andi Clemens
2009-02-21 11:17:29 UTC
Created attachment 31515 [details]
wrong options
This screenshot shows the differences.
On the left is the screen when I first created the search.
On the right is the screen when I edit the search.
As you can see, the matching conditions as well as the logical conjunction between the two groups changed.
But this is not the only issue. When I create the above search, it doesn't work as expected. I wanted to create a search where images are returned that have neither tag A nor tag B in it. But I always get images with only tag A assigned to them.
Another example: If I create a search like this:
(all conditions met: search all albums: tag A) AND
(all conditions met: search all albums: tag B)
I still get only the images with tag A assigned to them.
Something is broken here...
Andi
1. Another note on the advanced search dialog: I think it is way too big. We should at least put every search group into a tab, it is so hard to read. 2. Why does the first group header has a different arrangement of the conditions than the second? These headers are wasting a lot of space anyway. What do you think? Although there is a huge blue header, I still find it hard to distinguish between the two search groups. It would really help to have tabs here, mainly because a single search group itself can be 2 pages long, when every category has been expanded. Andi SVN commit 929571 by mwiesweg: Simplify: complex and buggy code is not necessary here (other parts are complex enough) CCBUG: 185106 M +1 -14 searchgroup.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=929571 SVN commit 929572 by mwiesweg: Add missing implementation for "OrNot" (which was not properly written or read as a consequence) BUG: 185106 M +5 -0 searchxml.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=929572 There is still a problem: When I edit a saved search, the changes go into "Current Search", not the one I edited. Andi SVN commit 929591 by mwiesweg: Backport: Add missing implementation for "OrNot" (which was not properly written or read as a consequence) CCBUG: 185106 M +5 -0 searchxml.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=929591 Works for me. I select any stored search except Current/Last Search, click on Edit Stored Search's Edit button, edit, click ok. The stored search is edited, Current/Last Search is untouched. I recompiled everything again (make clean) and now it seems to work here, too. I will watch this issue a little bit more... Andi Not reproducible with 7.0.0-beta1 |