Bug 184807

Summary:	calendar entries are written with MAILTO attribute even when there is no MAILTO value
Product:	[Applications] korganizer	Reporter:	Roland Wolters <bugs>
Component:	general	Assignee:	kdepim bugs <pim-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	smartins
Priority:	NOR
Version First Reported In:	3.5
Target Milestone:	---
Platform:	Debian stable
OS:	Unspecified
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Fixes the empty-value problem with MAILTO: property

Description Roland Wolters 2009-02-18 16:32:57 UTC

Version:            (using KDE 3.5.9)
Installed from:    Debian stable Packages

Currently when calendar data are written, the MAILTO property is stored even when there is no value given for the MAILTO URI. This results in calendar data lines like:
ORGANIZER;CN=Test User:MAILTO:
This, however, is not a valid URI. Therefore  several parsers throw a parse error at this property - the best example is the Funambol/Groupdav parser.

Th fix would be to check if the property has a value and only write it when a value is given.

Comment 1 Roland Wolters 2009-02-18 16:34:19 UTC

Created attachment 31439 [details]
Fixes the empty-value problem with MAILTO: property

The attached patch was written by Marco Nelles and fixes the above describe problem.

Comment 2 Sergio Martins 2009-02-19 00:03:22 UTC

It would be great if you adapted the patch so it could be applied to KDE4.2/trunk
and posted it to http://reviewboard.kde.org.

Or just attach the new patch and I'll post it there.


Thanks

Comment 3 Sergio Martins 2009-02-23 12:49:44 UTC

FYI

The patch was posted on review board: http://reviewboard.kde.org/r/148/

Comment 4 Allen Winter 2009-02-27 20:22:10 UTC

SVN commit 932997 by winterz:

Per RFC, if an organizer or attendee email address is empty, do not write that property.

Based on a patch by Marco Nelles, and reviewed at http://reviewboard.kde.org/r/148/

BUG: 184807



 M  +24 -11    icalformat_p.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=932997

Comment 5 Allen Winter 2009-02-27 20:35:03 UTC

SVN commit 933000 by winterz:

Don't add an ORGANIZER property if there is no email for the organizer.
CCBUG: 184807


 M  +8 -4      vcalformat.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=933000

Comment 6 Roland Wolters 2009-03-02 13:06:52 UTC

Any chance that this patch could be applied to KDE 3.5? I know that there is currently no further KDE 3.5 release planned, but just in case...