Bug 184637

Summary: potential data loss with image editor automatically switching file
Product: [Applications] digikam Reporter: Anders Lund <anderslund>
Component: ImageEditor-CoreAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: marcel.wiesweg
Priority: NOR    
Version: 0.10.0   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In: 0.10.0
Sentry Crash Report:

Description Anders Lund 2009-02-17 13:49:47 UTC 
Version:           0.10.0-rc2 (rev.: 917004) (using 4.2.00 (KDE 4.2.0), Arch Linux)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.28-ARCH

Select an image other than the first in an album to edit (F4)
Save the image
Edit it more, now you can not save (other issue) without renaming
Delete the image from the album
BANG - the image editor loads the next image, not asking to save your changes

There are more variants of this, basically if you delete the current or a previous image in the album, the image editor will load another one without asking to save.
Comment 1 Marcel Wiesweg 2009-02-21 16:39:37 UTC 
One can argue that this behavior is all right - if you delete an image you throw it away after all - but I think the intended workflow is to save with changes and delete afterwards, and deletion then is done before saving.
Comment 2 Anders Lund 2009-02-21 16:58:58 UTC 
You misunderstands what happens.
Image A is open in the editor, and edted.
I delete image B
The editor loads image C, discarding the edits in image A

My claim is that the image editor should *NOT* change image unless I explicitly asks it to!!!!!
Comment 3 Marcel Wiesweg 2009-02-21 17:43:07 UTC 
SVN commit 929574 by mwiesweg:

In removeItem(), do not touch urlCurrent if the removed item is not the current item.
In slotCollectionImageChange, do not trigger slotLoadCurrent unless the current item is deleted.

BUG: 184637

 M  +15 -4     imagewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=929574
Comment 4 Marcel Wiesweg 2009-02-21 18:11:32 UTC 
SVN commit 929592 by mwiesweg:

Backport:
In removeItem(), do not touch urlCurrent if the removed item is not the current item.
In slotCollectionImageChange, do not trigger slotLoadCurrent unless the current item is deleted.

CCBUG: 184637

 M  +19 -4     imagewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=929592
Comment 5 Anders Lund 2009-02-21 18:51:21 UTC 
Thank you!
I will update and enjoy not having this happening :-)