Bug 184408

Summary:	keyboard shortcut for displaying hidden files not the same in filepicker and dolphin/konqueror
Product:	[Unmaintained] kdelibs	Reporter:	Florian Hubold <doktor5000>
Component:	general	Assignee:	kdelibs bugs <kdelibs-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	andresbajotierra, faure, finex, peter.penz19
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Mandriva RPMs
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Proposed patch

Description Florian Hubold 2009-02-15 15:58:15 UTC

Version:            (using KDE 4.2.0)
OS:                Linux
Installed from:    Mandriva RPMs

When trying to display hidden files in any kde filepicker dialog i've seen, you need to press F8. But in dolphin/konqueror you do the same by pressing ALT+.
I have only taken kate as an example, because i didn't find the matching component.

This has been like this since KDE3, AFAIR.
Could this please be fixed so the same keys are used in both? I see no sense in using two completely different shortcuts for the same thing.

Comment 1 FiNeX 2009-02-15 23:08:02 UTC

I agree: the shortcut should be the same.

Comment 2 Dario Andres 2009-05-08 18:18:56 UTC

Is there any standard for this? Can this change be done before releasing KDE4.3?
Thanks

Comment 3 Peter Penz 2009-05-08 18:51:46 UTC

In Dolphin for KDE 4.3 F8 has been defined as alternative shortcut to Alt+. (-> both shortcuts work). In the file dialog only F8 works. I agree that this should be unified. I'm for sure not objective, but I think Alt+. should be the primary shortcut and F8 the alternative ;-)

Comment 4 Dario Andres 2009-05-08 19:43:14 UTC

Created attachment 33476 [details]
Proposed patch

This patch will set the Show Hidden Files action to have "Alt+." as default shortcut and "F8" as alternate.
The KAction is created inside KDirOperator, however I don't know if I should set the shortcuts there or in the filewidget...
Someone else has to review this

Comment 5 David Faure 2009-05-20 13:54:48 UTC

action() can return 0 if the name doesn't exist (the previous code assumed this wouldn't happen), and qobject_cast can also return 0 (if someone changes the code to ) --> I would add a null check ;)

I guess the point of not doing this in KDirOperator is that other users of it (e.g. KDevelop) might use F8 for other purposes already. So I think it's fine to keep doing it in KFileWidget.

Comment 6 Dario Andres 2009-05-20 14:39:31 UTC

SVN commit 970535 by darioandres:

Use the same shorcuts as Dolphin to show Hidden files
(Alt+. and F8). Review by dfaure (thanks)

BUG: 184408


 M  +6 -2      kfilewidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=970535