Bug 183178

Summary: [Windows] "Dowload album cover" downloads the cover but doesn't show it
Product: [Applications] amarok Reporter: Diego <diego.ml>
Component: generalAssignee: Amarok Developers <amarok-bugs-dist>
Status: RESOLVED FIXED    
Severity: normal CC: bjoernsc, casper.vandonderen, info, kde-windows, rdieter, yakov.shereshevsky
Priority: NOR    
Version: 2.1   
Target Milestone: ---   
Platform: unspecified   
OS: Microsoft Windows   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Amarok debug output on Windows while trying to download a cover.
Amarok debug output on Windows while trying to download a cover with last.fm.

Description Diego 2009-02-04 14:27:51 UTC
Version:           2.0.1 (using 4.2.00 (KDE 4.2.0), MS Visual Studio 2005 SP1)
Compiler:          cl.exe
OS:                Microsoft Windows (i686) release 5.1 (XP Professional)

This is easy to reproduce:
Install amarok for Windows, start playing something and then try to download the album cover. It looks like amarok actually downloads the covers (the progress bar goes from 0% to 100% for several times if, for example, you search for "Queen") but the window asking you if the cover it downloaded is the right one never appears. It behaves like it automatically skips to the next cover without asking anything.
When it cannot (or looks like it cannot) find more covers it shows correctly the window where it asks you if you want to change the search string.

In brief: it seems the only step skipped is the "ask if the cover is the right one"; the rest seems to work fine.
Comment 1 Bjoern Schroeder 2009-03-12 16:39:34 UTC
Can confirm that, even in the newest nightly builds.
Patrick and I are working on it.
Comment 2 Yakov 2009-04-25 15:45:20 UTC
confirm this in Linux Amarok 2.0.90
Cover is downloaded, and normally shows in full size, but preview doesnt changed.
Comment 3 Myriam Schweingruber 2009-05-26 13:46:51 UTC
Please check if this is still happening with the nightly-builds from that server:

http://mafia-server.net/amarok-nightly
Comment 4 Diego 2009-05-26 15:03:50 UTC
Installed the nightly-build but the issue is still there as before.
Comment 5 Diego 2009-05-27 14:07:08 UTC
Created attachment 34045 [details]
Amarok debug output on Windows while trying to download a cover.

Around second #12 you can see amarok trying to download the cover. Unfortunately it doesn't show the cover image.
Comment 6 Myriam Schweingruber 2009-08-02 14:43:56 UTC
Any news on this?
Comment 7 Diego 2009-08-06 18:51:02 UTC
Unfortunately nightly builds are no longer updated, and there are no other binary packages available at the moment. I'm too busy to compile from sources, so I'll let you know when updated packages will be published.
Comment 8 Myriam Schweingruber 2009-08-06 19:36:59 UTC
Casper, could you have a look at this, please?
Comment 9 Diego 2009-08-20 19:41:02 UTC
I'm experiencing a very similar issue in Linux too, so the issue could be indipendent from Windows. Maybe something that occasionally occurs in Linux, but always happen in Windows? Too vague to help the developers, I know...

To be precise I'm using:
- Fedora 10 + updates
- Amarok 2.1.1 on KDE 4.3.0

The only real difference I see from the Windows issue is that in Fedora the bar gets to 100% istantly, and there it stays.
Comment 10 Myriam Schweingruber 2009-08-20 19:48:55 UTC
(In reply to comment #9)

> The only real difference I see from the Windows issue is that in Fedora the bar gets to 100% instantly, and there it stays.

What bar are you talking about? Maybe you are talking about the memory leak in X and the cover manager reported in bug 197242, but I fail to see the relation to this bug here...
Comment 11 Diego 2009-08-20 20:03:58 UTC
(In reply to comment #10)
> (In reply to comment #9)
> 
> > The only real difference I see from the Windows issue is that in Fedora the bar gets to 100% instantly, and there it stays.
> 
> What bar are you talking about? Maybe you are talking about the memory leak in
> X and the cover manager reported in bug 197242, but I fail to see the relation
> to this bug here...

I was implicitly referring to the original report:
> It looks like amarok actually downloads the covers (the
> progress bar goes from 0% to 100% for several times if,
> for example, you search for "Queen") but the window asking
> you if the cover it downloaded is the right one never appears.

so the referral to the bar is to the download progress bar that appears in the lower right corner after you click "Download cover".
Comment 12 Diego 2009-08-28 18:39:21 UTC
Forget comment #9 and followings... the problem was due to Amazon problems I think, so it's unrelated to the Windows issue.
Comment 13 Diego 2009-09-04 17:20:38 UTC
Maybe this is fixed now that a new code that downloads covers from last.fm is in place. Does anybody who compiles from sources know?
Comment 14 Cyril Brosch 2009-09-17 22:37:43 UTC
The problem persists with the newest nightly build (2009-09-17).
It doesn't seem to have somthing to do with downloading, for me Amarok doesn't display any pictures, neither in the Wikipedia or fotos applet, adding covers manually doesn't work, too.
Comment 15 Diego 2009-10-01 14:09:31 UTC
I can confirm what Cyril says.

So, while the description still keeps valid the bug is different from the original report (due to the amazon -> last.fm change).
With today's nightly 01/10/2009 now I can see the downloaded cover (if it finds one of course) but clicking on "Save" gives no result.


Going to attach the debug output I get during the whole "Right click -> Fetch cover -> Save" process.
Comment 16 Diego 2009-10-01 14:12:06 UTC
Created attachment 37292 [details]
Amarok debug output on Windows while trying to download a cover with last.fm.
Comment 17 Bjoern Schroeder 2009-10-02 10:16:52 UTC
I think that the whole problem isn't really related anymore to the way how the covers are being fetched.
I think that they are fetched properly, but not being shown. The problem is, as far as i know, not a precice amarok, but kde problem. Maybe Patrick or Someone else could take a look at the whole image problem, because: The Youtube Applet, the Image Applet, the Wikipedia applet, the Info plugin in the Panel .... none of these is showing a single image ... i only have placeholders in there, but no image. So the question is: is amarok trying to use a function which isn't working properly in windows or is something wrong implemented in the kdelibs, because as far as i know, everyting worked until we start to build against KDE 4.2.x ...

Greetings

Bjoern
Comment 18 Myriam Schweingruber 2009-11-04 00:33:34 UTC
Any news on this? If it is not a problem in Amarok as suggested in the previous comment, we should assign this elsewhere?
Comment 19 Diego 2009-11-04 12:32:35 UTC
To make a long story short:
- the bug was not the original one since the change to last.fm;
- the images problem is present in KDE 4.3.0 packages (present in the amarok-nightly repo) but not in the 4.3.2 (thanks _Brandon_ and SaroEngels in IRC for the help).

Now also the splash screen shows up correctly.

Hooray!

So a temporary workaround until 4.3.2 or 4.3.3 packages are uploaded to amarok-nightly is to install Amarok nightly and then update KDE packages from a normal mirror.

To sum it up: Amarok 2.2.(nearly)1 + Phonon-VLC + KDE 4.3.2 = win!