| Summary: | webdav properties in wrong namespace | ||
|---|---|---|---|
| Product: | [Unmaintained] kio | Reporter: | Armijn Hemel <armijn> |
| Component: | http | Assignee: | kdelibs bugs <kdelibs-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | adawit, armijn, jospoortvliet, martin.sandsmark |
| Priority: | NOR | ||
| Version: | 4.9-Git | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | 4.8.1 | |
| Sentry Crash Report: | |||
| Attachments: | patch to remove 'executable' from the http kioslave | ||
Created attachment 43404 [details]
patch to remove 'executable' from the http kioslave
This one liner patch removes the 'executable' element from the XML that is sent by the kioslave, to make it comply with the official WebDAV standards.
The patch that I just sent does not remove the code that is parsing the response from the WebDAV server, it just removes the element from the XML. The code that parses the response should be rewritten too, but at least with this patch it is not sending out WebDAV requests that are WebDAV incompliant. Looks like WebDav ain't very actively maintained, sorry Armijnie-man ;-) could you please adapt your patch so instead of removing the functionality outright, it instead uses the correct namespace for the executable property? The executable property is an extension specific to the Apache WebDAV implementation only. Other WebDAV implementations do not implement this at all, so removing the property makes perfect sense right now. The apache webdav is at the moment the most popular webdav implementation in use, isn't it? And it would still be a regression removing the functionality. Eh? How can something that has been broken for at least a few *years* be a regression if it is removed? Anyway, the namespace should be http://apache.org/dav/props/ I'll try to come up with a new patch, time allowing. Related: WebDAV in KDE is pretty much broken in my opinion. You could do *so* much more with it and it would not be that difficult. The code would just need some love. If you want any action to be taken on WebDAV support, please report against the proper Product and component which is "kio" and "http" respectively. Otherwise, no one will ever find any patches you post and act upon them. Even though I am not the one that implemented WebDAV support in kio_http, I have been fixing several issues that were reported against it ; so if you report the issues to the right place, it will likely be acted upon. I apologise, I found it in the kdelibs directory, and I am not that intimate with the KDE source tree to realise it was actually kio. Thank you for reassigning it ot the right component :-) As I said above, the code that handles the 'executable' functionality has never worked because the property is in the wrong namespace. None of the Apache webservers out there has ever supported that property in this namespace. Git commit 066637a7bf200efea551532ae3f3723a7884cd30 by Dawit Alemayehu. Committed on 10/01/2012 at 22:25. Pushed by adawit into branch 'KDE/4.8'. Removed a non-standard WebDAV property (executable) from list of properties requested during a PROPFIND request. FIXED-IN: 4.8.1 M +0 -1 kioslave/http/http.cpp http://commits.kde.org/kdelibs/066637a7bf200efea551532ae3f3723a7884cd30 Git commit faec33ee91e01c29f6e83f03acbb836ed65a2d29 by Sebastian Trueg, on behalf of Dawit Alemayehu. Committed on 10/01/2012 at 22:25. Pushed by trueg into branch 'KDE/4.8'. Removed a non-standard WebDAV property (executable) from list of properties requested during a PROPFIND request. FIXED-IN: 4.8.1 M +0 -1 kioslave/http/http.cpp http://commits.kde.org/kdelibs/faec33ee91e01c29f6e83f03acbb836ed65a2d29 |
Version: (using Devel) Installed from: Compiled sources In kioslave/http/http.cpp there is the following snippet of "code": // No special request, ask for default properties request += "<D:prop>" "<D:creationdate/>" "<D:getcontentlength/>" "<D:displayname/>" "<D:source/>" "<D:getcontentlanguage/>" "<D:getcontenttype/>" "<D:executable/>" "<D:getlastmodified/>" "<D:getetag/>" "<D:supportedlock/>" "<D:lockdiscovery/>" "<D:resourcetype/>" "</D:prop>"; } request += "</D:propfind>"; Apart from the fact that this is a bit ugly to write XML (please, what's wrong with using a little bit of Qdom? There already is tons of it in there) there is also a bug. The 'executable' property is not part of the DAV: namespace according to the WebDAV specifications: http://www.webdav.org/specs/rfc4918.html but is an extension that is unique to mod_dav: http://www.webdav.org/mod_dav/ (see "mod_dav's custom properties"). If you read what it is meant to do it is best to remove it.