Bug 183046

Summary:	Dim screen for administrator mode breaks dialogs
Product:	[Plasma] kwin	Reporter:	Daniel Nicoletti <dantti12>
Component:	compositing	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Unspecified
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Daniel Nicoletti 2009-02-03 20:15:48 UTC

Version:            (using KDE 4.2.0)
Installed from:    Debian testing/unstable Packages

i don't know how can i explain that, but if you need more info just ask.
In kde4.2 we have a patch that adds polkit-kde to this effect, the problem is that i could only test it when 4.2 got out (and i installed the deb packages).
And now i found that this effect has a bug, which is not the patch fault but i don't have any idea of how to fix it. When the polkit-kde auth dialog appears the dim screen make the screen gets darken (obviously), but we have a combobox that if we click on it it simple don't show the items, i can navigate through them with (up/down keys) but the list don't appear. If i remove the effect it works fine.
If you don't want to install polkit-kde you can call kdesu and use the what's this "?" popup that don't show anything either, actually i noticed that the what's this shows it's popup behind the kdesu dialog.

Thanks,
btw polkit-kde is going to be include in 4.3 so it'd be nice to have it fixed soon :D

Comment 1 Martin Flöser 2009-02-03 20:29:02 UTC

Yes I understand the reason. The dialog is painted above all other windows. So the combobox is painted below the dialog.

The effect needs a big rework or should be dropped in 4.3. There are some issues with it and Lubos has never been happy about.

Comment 2 Martin Flöser 2009-02-09 15:59:16 UTC

SVN commit 923844 by graesslin:

Rework of dim screen for administration mode effect. Now it changes brightness and saturation of all windows instead of painting a semi-transparent area on the screen. And it works nicely with fullscreen effects. So the windows are not dimmed in e.g. coverswitch.
BUG: 183046


 M  +36 -93    dimscreen.cpp  
 M  +5 -16     dimscreen.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=923844

Comment 3 Daniel Nicoletti 2009-02-13 19:37:11 UTC

Thanks Martin for the quick fix, but it is still not perfect :P
the combobox list is now dimmed too :(
At least we can see it now :D

Comment 4 Martin Flöser 2009-02-13 19:45:49 UTC

(In reply to comment #3)
> Thanks Martin for the quick fix, but it is still not perfect :P
> the combobox list is now dimmed too :(
> At least we can see it now :D
So it's an improvement to before ;-)

Problem is I can't test it as I do not yet have policykit... I set option to not dim comboboxes, seem's this does not yet work reliable.

Comment 5 Daniel Nicoletti 2009-02-13 20:08:54 UTC

(In reply to comment #4)
> (In reply to comment #3)
> > Thanks Martin for the quick fix, but it is still not perfect :P
> > the combobox list is now dimmed too :(
> > At least we can see it now :D
> So it's an improvement to before ;-)
> 
> Problem is I can't test it as I do not yet have policykit... I set option to
> not dim comboboxes, seem's this does not yet work reliable.
> 
Yep, it is an improvement :D
if you don't want to install policykit you could try creating a dummy application that has a combobox list and add that to the applications list of your effect.
I wish i could help testing but i'm out of space to download trunk here. I need a new HD :P

Comment 6 Martin Flöser 2009-03-08 17:53:32 UTC

SVN commit 936926 by graesslin:

Don't dim unmanaged windows.
BUG: 183046


 M  +1 -2      dimscreen.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=936926

Comment 7 Daniel Nicoletti 2009-03-08 20:12:52 UTC

Thanks a lot graesslin :D
Lukas tested it and worked pretty fine