| Summary: | Allow user to change background colour | ||
|---|---|---|---|
| Product: | [Applications] okular | Reporter: | Claus Appel <spectrumdt> |
| Component: | general | Assignee: | Okular developers <okular-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bluedzins, f.glopez, jan.kaspar, lucienlaoz, nate, simonandric5, tguenther.dev |
| Priority: | NOR | ||
| Version First Reported In: | 0.7.4 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/okular/1f6e8a4782f6f750daf893709e1a043096a837fe | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Claus Appel
2009-02-03 13:57:52 UTC
I fully support this wish. The white background can sometimes can be very unfortunate - an example: for my presentations I use logos which are white/transparent. On white background you cannot see anything... A custom background color might be a good option. Or a checked pattern background (like in Gimp for transparent background)... Kašpi Jan, I believe you are talking about document background color ("paper" color), not about okular background (and this wish is about that).
You're right, Maciej. Moreover I realized that one can change the paper color in Okular settings. Thus, please, forget my previous posting. Thanks, Jan. *** Bug 307116 has been marked as a duplicate of this bug. *** *** Bug 319736 has been marked as a duplicate of this bug. *** *** Bug 372055 has been marked as a duplicate of this bug. *** Git commit 6b5a7c9a1a00dec994cfb03b0abf369539168758 by Nathaniel Graham.
Committed on 01/10/2017 at 01:45.
Pushed by ngraham into branch 'master'.
Custom background color
Summary:
Adds an option to the config dialog that enables background color (the color around the displayed page) to be changed (while by default preserving the Qt toolkit selection as not to affect existing users).
Reasons for this change:
Accessibility, eye strain, aesthetic reasons, color displayed on monitor can affect power consumption (how: depends on display technology).
Many people want this change occording to Bugzilla and other sources.
Maintenance: Nearly no additional maintenance:
This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular.
{F4257766}
Other less important information:
https://git.reviewboard.kde.org/r/130219/
https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html
Test Plan:
Tested everything, it all works:
Toggled the custom background color, changed custom background color, removed okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual qt theme colour by default (where the settings file remembered the custom color).
Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham
Reviewed By: ngraham
Subscribers: aacid, ltoscano, ngraham
Tags: #okular
Differential Revision: https://phabricator.kde.org/D8051
M +2 -2 CMakeLists.txt
M +7 -0 conf/dlggeneral.cpp
M +3 -0 conf/dlggeneral.h
M +59 -2 conf/dlggeneralbase.ui
M +5 -0 conf/okular.kcfg
M +6 -1 ui/pageview.cpp
https://commits.kde.org/okular/6b5a7c9a1a00dec994cfb03b0abf369539168758
Git commit 1f6e8a4782f6f750daf893709e1a043096a837fe by Luigi Toscano, on behalf of Albert Freeman.
Committed on 01/10/2017 at 09:31.
Pushed by ltoscano into branch 'master'.
Custom background color
Summary:
Adds an option to the config dialog that enables background color (the color around the displayed page) to be changed (while by default preserving the Qt toolkit selection as not to affect existing users).
Reasons for this change:
Accessibility, eye strain, aesthetic reasons, color displayed on monitor can affect power consumption (how: depends on display technology).
Many people want this change occording to Bugzilla and other sources.
Maintenance: Nearly no additional maintenance:
This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular.
{F4257766}
Other less important information:
https://git.reviewboard.kde.org/r/130219/
https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html
Test Plan:
Tested everything, it all works:
Toggled the custom background color, changed custom background color, removed okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual qt theme colour by default (where the settings file remembered the custom color).
Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham
Reviewed By: ngraham
Subscribers: aacid, ltoscano, ngraham
Tags: #okular
Differential Revision: https://phabricator.kde.org/D8051
M +2 -2 CMakeLists.txt
M +7 -0 conf/dlggeneral.cpp
M +3 -0 conf/dlggeneral.h
M +59 -2 conf/dlggeneralbase.ui
M +5 -0 conf/okular.kcfg
M +6 -1 ui/pageview.cpp
https://commits.kde.org/okular/1f6e8a4782f6f750daf893709e1a043096a837fe
|