Bug 182980

Summary:	Time format show AMPM not am or pm
Product:	[Applications] systemsettings	Reporter:	Zayed Al-Saidi <zayed.alsaidi>
Component:	general	Assignee:	Zayed Al-Saidi <zayed.alsaidi>
Status:	RESOLVED FIXED
Severity:	normal	CC:	andresbajotierra, caslav.ilic
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Unspecified
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	This screenshot shows the problem. the new kcmlocale.po

Description Zayed Al-Saidi 2009-02-03 12:53:21 UTC

Version:            (using KDE 4.2.0)
Installed from:    SuSE RPMs

When I choose time format pH:MM:SS AMPM, I suppose I get like this 01:30 pm. But I get 01:30 AMPM. I've searched the PO file kcmlocale.po and I can not find pm or am entry, which mean there are not exist. In kde4.1 very thing works fine.

Comment 1 Dario Andres 2009-02-03 14:21:47 UTC

What locale are you using? If it's non-english, does this happen also if you start SystemSettings in English? (running "LANG=C systemsettings" or "LANG=EN systemsettings")
Thanks

Comment 2 Zayed Al-Saidi 2009-02-03 15:50:01 UTC

I use Arabic (Oman). When I try "LANG=EN systemsettings" everything is OK. It seem there is some thing missing in kcmlocale.po.

By the way I'm the person who translate kcmlocale.po to Arabic.

Comment 3 Zayed Al-Saidi 2009-03-05 01:02:13 UTC

I use kde 4.2.1 with Qt4.5 and this bug has gone !!

Comment 4 Zayed Al-Saidi 2009-07-07 15:33:17 UTC

Created attachment 35121 [details]
This screenshot shows the problem.

I face this problem again in the KDE4.3 RC1. I think opensuse does something in their version of Qt to fix this. 

I translate AM and PM entries in the kdeqt.po but it seems root of this problem is not in the translation.

Comment 5 Zayed Al-Saidi 2009-07-07 15:34:28 UTC

Chusslove, what do you think ?

Comment 6 Chusslove Illich 2009-07-07 15:53:35 UTC

It is a translation problem in kcmlocale catalog. Messages "HH" through
"WEEKDAY" (17 total) are actually keywords, which the user may insert into
the format string to have the desired element of time or date. They can be
left as is, or translated using any letters (not just ASCII), but must have
no spaces in them. Whatever is done, these keywords must then also be
consistently used throughout.

So the problem with am/pm comes because message "AMPM" is translated to
Arabic, but its translation is not used in other places (e.g. in the message
with context "some reasonable time formats for the language", or in the long
explanatory message about time format).

Comment 7 Zayed Al-Saidi 2009-07-07 17:36:25 UTC

Created attachment 35125 [details]
the new kcmlocale.po

@ Chusslove 

I fixed the keywords by just copy them without any modification. This fix the preview pane only. The Plasma calendar plasmoid still showing AMPM. Moreover, when I change the country (for example Jordon), the preview pane show AMPM again!

Comment 8 Chusslove Illich 2009-07-07 17:47:35 UTC

The wrong settings have been remember verbatim in KDE configuration, so open
~/.kde/share/config/kdeglobals and remove every entry with ...Date...= in
it. That ought to revert date formats to defaults, which should be correct
after the translation fix.

Comment 9 Zayed Al-Saidi 2009-07-07 18:16:18 UTC

Thanks Chusslove that solve the problem. I will commit the new kcmlocale.po in the next patch of translation.

Comment 10 Chusslove Illich 2009-07-07 18:19:53 UTC

Superb, then we can close this bug.