Summary: | Empty page appears for http://www.webtoolkit.eu/wt | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | András Manţia <amantia> |
Component: | khtml | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | SVN | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: | patch (w/some debug output that needs removing) |
Description
András Manţia
2009-01-29 00:24:37 UTC
Have it fixed in my tree now,but too tried to pull out the diff. Created attachment 30789 [details]
patch (w/some debug output that needs removing)
The attached fixes it + makes a mthod name saner.
SVN commit 922955 by orlovich: Some fixes for our stylesheets collection to fix http://www.webtoolkit.eu/wt: 1) Make sure that we create a stylesheet object even for empty <style> elements 2) Keep track of dirtiness of stylesheets list separately from that of the style selector, and make sure to rebuild it if the collection is accessed. While I am at it, instead of having confusingly similarly named recalcStyleSelector and rebuildStyleSelector, have rebuildStyleSelector and rebuildStyleSheetList, the difference between which should be evident. Also make them private. (Though updateStyleSelector is not renamed, so things aren't 100% clear, still) BUG: 182230 M +15 -0 css/css_stylesheetimpl.cpp M +9 -1 css/css_stylesheetimpl.h M +11 -0 html/html_headimpl.cpp M +2 -0 html/html_headimpl.h M +27 -12 xml/dom_docimpl.cpp M +8 -2 xml/dom_docimpl.h WebSVN link: http://websvn.kde.org/?view=rev&revision=922955 SVN commit 922959 by orlovich: Merged revision 922955: Some fixes for our stylesheets collection to fix http://www.webtoolkit.eu/wt: 1) Make sure that we create a stylesheet object even for empty <style> elements 2) Keep track of dirtiness of stylesheets list separately from that of the style selector, and make sure to rebuild it if the collection is accessed. While I am at it, instead of having confusingly similarly named recalcStyleSelector and rebuildStyleSelector, have rebuildStyleSelector and rebuildStyleSheetList, the difference between which should be evident. Also make them private. (Though updateStyleSelector is not renamed, so things aren't 100% clear, still) BUG: 182230 M +15 -0 css/css_stylesheetimpl.cpp M +9 -1 css/css_stylesheetimpl.h M +11 -0 html/html_headimpl.cpp M +2 -0 html/html_headimpl.h M +27 -12 xml/dom_docimpl.cpp M +8 -2 xml/dom_docimpl.h WebSVN link: http://websvn.kde.org/?view=rev&revision=922959 SVN commit 922964 by orlovich: Regression test for #182230 CCBUG:182230 A baseline/ecma/stylesheet-collection.html-dom AM baseline/ecma/stylesheet-collection.html-dump.png A baseline/ecma/stylesheet-collection.html-render A tests/ecma/empty.css A tests/ecma/stylesheet-collection.html WebSVN link: http://websvn.kde.org/?view=rev&revision=922964 |