Bug 182212

Summary: zoom to fit in image editor is not always sticky
Product: [Applications] digikam Reporter: Anders Lund <anderslund>
Component: ImageEditor-CanvasAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: marcel.wiesweg
Priority: NOR    
Version: 0.10.0   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In: 0.10.0
Sentry Crash Report:

Description Anders Lund 2009-01-28 22:54:56 UTC 
Version:           0.10.0-rc2 (rev.: 917004) (using 4.2.00 (KDE 4.2.0), Arch Linux)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.28-ARCH

When cropping or resizing an image, the 'fit to window' state fails to stick. This worked very well in the previous (0.9.x) version!
Comment 1 Marcel Wiesweg 2009-01-31 23:18:04 UTC 
Can't reproduce here.
I open an image, Fit to Window is selected.
I crop or resize, Fit to Window is still selected and the image is resized accordingly.
Any special settings or situations to reproduce this?
Anyone else to reproduce this?
Comment 2 Marcel Wiesweg 2009-02-13 19:14:41 UTC 
Anders, please give me a detailed use case how to reproduce. I can't do anything without.
Use one of the sample images http://digikam3rdparty.free.fr/TEST_IMAGES/ to rule out any influence from chosen image. If you can reproduce the problem, we need to find out what is different on your system.
Comment 3 Anders Lund 2009-02-15 09:15:52 UTC 
Hi Marcel,
Sorry for being slow.

Take an image (I imported http://digikam3rdparty.free.fr/TEST_IMAGES/JPEG/Horizontal/BKO132582.jpg), open it and enable "fit to window" in the toolbar.

Use any tool that has the embedded dialog, for example "Aspect ratio crop". Ok the tool, when the main view is back the "fit to window" button is not in pressed state, although the image is still fitted.
Comment 4 Marcel Wiesweg 2009-02-21 22:51:22 UTC 
SVN commit 929686 by mwiesweg:

Do not try to restore a zoom level if fitToWindow is set.

BUG: 182212

 M  +2 -1      editortooliface.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=929686
Comment 5 Marcel Wiesweg 2009-02-21 23:43:04 UTC 
Note: fix is in 0.11. I dont feel well backporting to 0.10.
Comment 6 Anders Lund 2009-02-21 23:44:59 UTC 
I'm currently running trunk, would that be 0.11?
Comment 7 caulier.gilles 2009-02-22 09:23:35 UTC 
SVN commit 929799 by cgilles:

backport commit #929686 to trunk 
CCBUGS: 182212


 M  +2 -1      editortooliface.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=929799
Comment 8 caulier.gilles 2009-02-22 09:29:11 UTC 
SVN commit 929803 by cgilles:

backport commit #929686 to kde3 branch
BUG: 182212


 M  +3 -2      editortooliface.cpp  
 M  +1 -1      editortooliface.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=929803