Bug 181981

Summary: To-do and event editor asks whether really to cancel, even if nothing was changed
Product: [Applications] korganizer Reporter: René Krell <renda.krell>
Component: generalAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: reinhold, smartins
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:

Description René Krell 2009-01-26 15:18:55 UTC
Version:           4.2 rc1 (using 4.1.96 (KDE 4.1.96 (KDE 4.2 RC1)) "release 78.2", KDE:KDE4:Factory:Desktop / openSUSE_11.1)
Compiler:          gcc
OS:                Linux (i686) release 2.6.27.7-9-default

If I open entries of my To-do list for editing (Edit To-do) and press immediately <ESC> or click on <Cancel> I#m asked whether really to cancel. This is annoying from my point of view and should appear only if the entry was changed. I mark this a bug assuming this was not actually wanted.
Comment 1 René Krell 2009-01-26 15:45:36 UTC
Additional note: I use korganizer from within Kontact, if this plays a role.
Comment 2 Sergio Martins 2009-02-03 03:15:10 UTC
Confirmed in current trunk
Comment 3 Reinhold Kainhofer 2009-02-17 12:22:05 UTC
I also find this highly annoying. The message box asking whether you really want to cancel is useful if you have changed anything, so that you don't loose your changes. But when you haven't changed anything, pressing cancel should simply close the editor dialog!
Comment 4 Sergio Martins 2009-03-05 02:46:07 UTC
SVN commit 935416 by smartins:

Don't to "really close" if now changes were made.
Renamed the writeFoo methods to fillFoo.


Review board: http://reviewboard.kde.org/r/229
BUG:181981
CCBUG:184570


 M  +1 -1      koattendeeeditor.cpp  
 M  +1 -1      koattendeeeditor.h  
 M  +1 -1      koeditorattachments.cpp  
 M  +1 -1      koeditorattachments.h  
 M  +2 -2      koeditordetails.cpp  
 M  +1 -1      koeditordetails.h  
 M  +2 -2      koeditorfreebusy.cpp  
 M  +1 -1      koeditorfreebusy.h  
 M  +2 -2      koeditorgeneral.cpp  
 M  +1 -1      koeditorgeneral.h  
 M  +2 -2      koeditorgeneralevent.cpp  
 M  +1 -1      koeditorgeneralevent.h  
 M  +1 -1      koeditorgeneraljournal.cpp  
 M  +1 -1      koeditorgeneraljournal.h  
 M  +2 -2      koeditorgeneraltodo.cpp  
 M  +1 -1      koeditorgeneraltodo.h  
 M  +1 -1      koeditorrecurrence.cpp  
 M  +1 -1      koeditorrecurrence.h  
 M  +19 -9     koeventeditor.cpp  
 M  +2 -1      koeventeditor.h  
 M  +15 -7     koincidenceeditor.cpp  
 M  +5 -0      koincidenceeditor.h  
 M  +17 -7     kojournaleditor.cpp  
 M  +2 -1      kojournaleditor.h  
 M  +18 -8     kotodoeditor.cpp  
 M  +2 -1      kotodoeditor.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=935416