| Summary: | Image Editor's "fit-to-window" is broken when invoking a filter | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Andi Clemens <andi.clemens> |
| Component: | ImageEditor-Plugins | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 0.10.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 0.10.0 | |
| Sentry Crash Report: | |||
|
Description
Andi Clemens
2009-01-26 11:01:15 UTC
Note: there are 2 cases: editor tool is use image preview widget with zomming feature (sharp for ex.) or not (curves for ex.). With Sharp tool: 1/ fit to window in editor, start sharp tool => fit to window action is disabled 2/ apply sharp tool => fit to window action is enabled and zoom level restored (it can be changed a little but this is duing to right sidebar splitter size changes. With Curves tool: like there is no zooming feature here, zoom+ and zoom- actions must be disabled (this is not the case, but actions do not have effect) All interaction betwen zoom action and tool are here : http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/editorstackview.cpp Code to switch on/off standard action in editor is here : http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/editorwindow.cpp#973 ...and is called by: http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/editortooliface.cpp#098 http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/editortooliface.cpp#109 Gilles Is there a reason why we don't allow zooming in curves tool? It can be very useful to zoom in, when I use Gimp and the curve tool in there, I zoom a lot to see that I am not loosing too many details. This is the purpose to factorize all image plugins preview widget to a commun implementation Gilles Ok so we will do better here :-) Andi Zoom is acting weird in general, found another issue: 1. Open a plugin that can zoom 2. Zoom out until the zoom out action is disabled 3. toggle fit-to-window 4. zoom in: zoom out action will not be enabled (sometimes it will when zooming to 400% or more) I think we should not put too much effort in this right now, it seems to be a bigger problem and is easier to fix when switching to the new editor preview widget? Andi SVN commit 916945 by cgilles: digiKam from trunk : fix some issues with zoom action between canvas and editor tool preview. For the moment, only Zoom+ and Zoom- actions are properly managed. Later, when all Editor Tool preview widget will be factored, we will improve zoom management to include Zoom Fit and Zoom Combox. BUG: 181964 M +6 -8 editorstackview.h M +11 -0 editortooliface.cpp M +14 -19 editorwindow.cpp M +1 -0 editorwindow.h WebSVN link: http://websvn.kde.org/?view=rev&revision=916945 |